Giter VIP home page Giter VIP logo

Comments (7)

AbdelrhmanHamouda avatar AbdelrhmanHamouda commented on June 2, 2024 1

most of development has concluded.
Pending:

  • HELM control
  • AWS nodeGroups verification

from locust-k8s-operator.

AbdelrhmanHamouda avatar AbdelrhmanHamouda commented on June 2, 2024

Initial thoughts are to use nodeAffinity instead of nodeSelector. Also to use requiredDuringSchedulingIgnoredDuringExecution instead of preferredDuringSchedulingIgnoredDuringExecution.

Currently investigating the definition and placement of the interface for this feature.

Tasks list:

  • Investigation of possible solutions
  • Definition of feature interface
  • Implementation (with support for multiple labels)
  • Testing
  • Verification with AWS EKS nodeGroups
  • Documentation

from locust-k8s-operator.

AbdelrhmanHamouda avatar AbdelrhmanHamouda commented on June 2, 2024

Feature Plan

Support Kubernetes node affinity specifically requiredDuringSchedulingIgnoredDuringExecution.

Configuration & interface

The feature will have two methods of configuration & interface allowing for more refined control.

Method 1

CRD & CRs

  • **node Affinity **: Optional section to allow the declaration of nodeSelectorTerms in a way that closely matches Kubernetes "look & feel" of declaring. The operator field value will be a direct match to everything that Kubernetes support today (i.e. In, NotIn, Exists, DoesNotExist, Gt and Lt). Reference docs.
    example:
spec:
  affinity:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
           matchExpressions:
               - key: disktype
              operator: In
              values:
                 - ssd  
  • **Taints and Tolerations **: An Optional section to allow adding Taint tolerations to generated resources. The support will be modelled to closely follow Kubernetes Taints & Tolerations docs

Method 2

HELM

  • Default affinity key/value pairs, sensible defaults will be provided by the team / individual owning the operator in the cluster. if unset / unused, the field will default to null meaning that the controller will not inject node affinity labels by default. This will follow a similar structure to the one defined in the CRD.
  • Default Taint tolerations: A list of default tolerations to be added to generated resources
  • Affinity Allow list, A list of allowed affinity keys & values so when an override comes through a deployed CR, the Controller will check if it is allowed or not. default is null meaning allow all overrides.
  • Allow overrides, simple switch to enable / disable overrides.

from locust-k8s-operator.

jamessthompson avatar jamessthompson commented on June 2, 2024

Thank you for your work on this operator.

This feature is exactly what we need. I see you've merged a few PRs to implement it, do you know when you plan to release it? If a release isn't planned soon, is it in a usable state if we compile it ourselves?

from locust-k8s-operator.

AbdelrhmanHamouda avatar AbdelrhmanHamouda commented on June 2, 2024

Hello @jamessthompson,
Glad to see that you are utilising the project. I would be interested to hear about how it is being utilised and your experience with it so far if you are willing to share.

The feature will be released in few days at the most along with related documentation. Feel free to check the linked PR and voice your thoughts if you wish.

from locust-k8s-operator.

jamessthompson avatar jamessthompson commented on June 2, 2024

This week, we determined that we need to do a large load test of our system before the end of the month. With that short timeline, we decided our first attempt would use locust, a tool I've used in the past. While the locust helm chart would work, your operator would make load tests easier to maintain in the long run, so we figured we'd start with it.

We need the functionality in this feature request to configure this specific load test to provision pods on nodes in public subnets.

from locust-k8s-operator.

AbdelrhmanHamouda avatar AbdelrhmanHamouda commented on June 2, 2024

HELM changes have been merged and feature has been released.

Usage documentation can be found under the "Advanced Topics" section in the documentation.

from locust-k8s-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.