[Bug] Image format extensions messed up about ghost-on-github-pages HOT 32 CLOSED

Thank you, all images are loading now 👍

from ghost-on-github-pages.

@paddy420Smokers I will look on it soon

from ghost-on-github-pages.

Hi @abhijithvijayan ,
I'm facing the exact issue, Any updates on the solution?

from ghost-on-github-pages.

Hi @abhijithvijayan ,
Adding the following lines which mimics the .jpg format in deploy.sh, fixed this!

find static -name *.html -type f -exec sed -i '''s#.pngg 600w#''.png 600w''#g' {} \;		
find static -name *.html -type f -exec sed -i '''s#.pngng 1000w#''.png 1000w''#g' {} \;
find static -name *.html -type f -exec sed -i '''s#.pngpng 2000w#''.png 2000w''#g' {} \;

from ghost-on-github-pages.

Could you send a PR for this?

from ghost-on-github-pages.

Absolutely !!!!

from ghost-on-github-pages.

Sure. I will accept PRs

wget can then replace p2 dependancy issue and buster deprecation.

I prefer ghost over everything I have ever used. It's so easy to use and SEO friendly and with wget, this can have SSG.

from ghost-on-github-pages.

@tejakummarikuntla

Your build is not successful with patched links. I will fix the script.

from ghost-on-github-pages.

@Paritosh-Negi I will look onto it asap.

Please confirm if you used the instructions from this project's readme.

from ghost-on-github-pages.

Yes, I followed the instructions carefully twice; still, images are not loading.

from ghost-on-github-pages.

@Paritosh-Negi can reproduce the issue, I guess it is the issue with buster tool.

Let me see if I can manually fix that with some changes to the script.

from ghost-on-github-pages.

@Paritosh-Negi I have fixed the issue.

Checkout new demo

Steps to fix:
Delete the existing deploy.sh script and replace with new content from https://raw.githubusercontent.com/abhijithvijayan/ghost-on-github-pages/master/deploy.sh

Give execute permission(one time only)

chmod u+x deploy.sh

Then deploy with
./deploy.sh

Feel free to reopen the issue if this doesn't solve your issue.

from ghost-on-github-pages.

Hi, Im still getting the error.

from ghost-on-github-pages.

Did you use the new script? Also create a demo repo.

from ghost-on-github-pages.

Yes Ive used the new script. Do I need a demo repo for it to work? Anyway thanks for your quick reply. Thought this thread was dead.

from ghost-on-github-pages.

Heres the Demo Ive setup: https://paddy420smokers.github.io/cannalogie/ (You can see that the first changed image is not appearing.)

Git Rep: https://github.com/paddy420Smokers/cannalogie

Note: Ive changed the port from 2368 (Its already in use) to 2380. Ive changed the port in the new deploy.sh and in the development.js did I miss something?

Also Im struggling with the Image bug for a few weeks now. I hope you can help me! Thanks again for your great work :)

from ghost-on-github-pages.

I can see that something messes up with the Image ending

Check the attached picture.

from ghost-on-github-pages.

This is an easy fix.

I didnt get any updates on this, hence I missed.

This is caused by new major changes in ghost and buster deprecation.

Even though buster is deprecated, minor tweaks on deployment script can make ghost fully work like before.

from ghost-on-github-pages.

No @abhijithvijayan , I didn't see its fixed.
The image extensions are getting messed up still.

from ghost-on-github-pages.

Will get this fixed asap.

Could you attach the image source(the messed up content)?

from ghost-on-github-pages.

I don't think the issue is with Buster ,
I tried doing the same thing with Wget, [I didn't use Buster here]
wget -r -nH -P docs -E -T 2 -np -k http://localhost:2368/
Ref
Still, I find the same issue coming up, probably the issue is due to the latest update of Ghost.

from ghost-on-github-pages.

The deployment script here has fix for png files, all it takes is same code for jpg

If you could attach the html image broken source here, I can attach the resolution as well

from ghost-on-github-pages.

Also thanks for suggesting way to use wget

I will migrate the instructions and script and fix all that issue and let you know

from ghost-on-github-pages.

No @abhijithvijayan , I didn't use any JPG files, all I used is PNG.
Please find the attachment.

from ghost-on-github-pages.

@abhijithvijayan
This filename issue is occurring at three diff location which reflects at post-card-image image class.

1. static/index.html
2. static/PUBLISHED_BLOG_TITLE/index.html
3. static/tag/CORRESPONDING_PUBLISHED_BLOG_TAG/index.html

from ghost-on-github-pages.

@tejakummarikuntla

As this issue was raised once before, I pushed a fix to resolve this, it was resolved to jpg images only.

As now with png, its a simple fix. All it takes is copying these lines as that of png

from ghost-on-github-pages.

@tejakummarikuntla Thanks.

Just one thing, buster generated urls as per user, does wget breaks the asset links or something without doing so?

from ghost-on-github-pages.

But @abhijithvijayan , I think we gotta another problem.
The mobile view from chrome is totally fine, but the entire webpage is totally messed up when I open the site on my mobile.

• I faced this issue even before the .png fix [Only for this (Casper (default) theme)]
  Any possible solution?
  http://tejakummarikuntla.github.io/blog

• I didn't find this issue when I left Buster and went for Wget approach. It was totally working fine.
  this is by using wget: http://tejakummarikuntla.github.io/bog_wget

from ghost-on-github-pages.

@tejakummarikuntla Could you attach the live link of the site?

I will take a look at it.
Probably wget broke something.

from ghost-on-github-pages.

@abhijithvijayan ,
I tried using the png, jpg typo clearing bash script on Wget generated files instead of Buster generated files. It worked really well, I don't see any issues with the Mobile view now.
As we can see various issues are rising with Buster which requires py2 dependency as well.

Why don't we use Wget in this project instead of Buster. What do you say?

from ghost-on-github-pages.

@tejakummarikuntla Everything is set to use wget

The script fixes jpeg, jpg, png image formats.

Everything seems to work flawlessly.

Try again with the latest script and feel to reopen this issue, if anything comes up.

from ghost-on-github-pages.

Hi @abhijithvijayan ,

I have found some problem when I run your deploy.sh on my Macbook Pro, and I have fixed it :)

• The sed shell command which trying to replace jpgg with jpg
• The sed shell symbol in the command which trying to replace localhost:2368 with username and gh_repo.
• The Fixing Images step should be to do on the setup step.
• The master branch had been replaced with main branch by Github team at 2020/10, so you don't need to create master and gh-pages branch.

I will send the PR to you.

from ghost-on-github-pages.