Hardcoded path in scripts.go about caddy-git HOT 16 CLOSED

You're welcome.

And thanks @ekollof for this issue and fix :)

from caddy-git.

Oops, thanks for pointing that you. Do you mind submitting a PR for this ?

from caddy-git.

The change from PR #58 seem to break the plugin for me. I'm getting the below message in the log when Caddy tries to update the git repo. I just rebuilt Caddy with the plugin from the caddy homepage.

/usr/bin/env: ‘bash ’: No such file or directory
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
2017/05/12 06:36:44 exit status 1

The env command works fine in the shell:

$ /usr/bin/env bash --version
GNU bash, version 4.3.46(1)-release (x86_64-pc-linux-gnu)
$ which env
/usr/bin/env
$ which bash
/bin/bash

Distribution: Ubuntu 16.04.2 LTS x86_64

from caddy-git.

from caddy-git.

Oops. the whitespace most likely. Should be pushing a fix soonest.

from caddy-git.

I am unable to reproduce this both on Mac and on Linux.
Something looks weird here.

from caddy-git.

@eripa, what happens if you run /usr/bin/env bash in a terminal?

from caddy-git.

Strange indeed @abiosoft

@ekollof I updated the original post before, in summary it works fine.

from caddy-git.

I've downloaded from caddyserver.com, built from source and tested both on linux and windows for both private and public repositories and it works as expected.

from caddy-git.

@abiosoft What Linux dist are you using? (mostly thinking about the init system)

from caddy-git.

Good point. I was just using containers based off Alpine. Let me try using an Ubuntu 16.0.4.2 image.

from caddy-git.

I do know Ubuntu is a bit weird when it comes to bash, with them using dash as a default shell. But still, that shouldn't break env. Unless if they mess with the ${PATH}

from caddy-git.

Ok, I'm thinking maybe it's some systemd environment configuration weirdness. Alpine is much more straight forward!

from caddy-git.

I just tried in an ubuntu 16.04 image as well. Also works.

Can you try with another distro. While at that. I'll push out a minor fix (remove a whitespace that I do not expect to cause problems) and let me know if that changes anything.

from caddy-git.

@eripa I've successfully deployed the fix for whitespace removal. Can you try again now ?

from caddy-git.

Quite strange that it didn't work on my Ubuntu.

@abiosoft your commit fixed the issue, thanks a lot!

from caddy-git.