Date display doesn't take into account system locale about gource HOT 2 OPEN

Thanks for pointing this out and also providing a solution. If it did this and the person has a non English time locale, the text representation of the date would be incorrect? I suppose there is a general solution for this.

from gource.

Here's an example of using strftime with different locales on an online Visual C++ compiler: http://rextester.com/CZTQY99923

Source:

#include <iostream>
#include <ctime>

using namespace std;

int main()
{
    char str[200];
    time_t currTime = time(NULL);
    
    // Default locale
    strftime(str, sizeof(str), "%#x", localtime(&currTime));
    cout << "Default \"C\" Locale (Implicitly-set): " << str << endl; 
    
    // setlocale "C" should also be the Default locale
    setlocale(LC_ALL, "C");
    strftime(str, sizeof(str), "%#x", localtime(&currTime));
    cout << "Default \"C\" Locale (Explicitly-set): " << str << endl; 
    
    // setlocale "" should be the user's system locale
    setlocale(LC_ALL, "");
    strftime(str, sizeof(str), "%#x", localtime(&currTime));
    cout << "User/System Locale: " << str << endl; 
    
    // setlocale "lang-COUNTRY" should set that specific locale
    setlocale(LC_ALL, "es-ES");
    strftime(str, sizeof(str), "%#x", localtime(&currTime));
    cout << "Spanish (Spain) locale: " << str << endl; 
}

Here's the output I get from that site currently:

Default "C" Locale (Implicitly-set): Saturday, April 22, 2017
Default "C" Locale (Explicitly-set): Saturday, April 22, 2017
User/System Locale: Samstag, 22. April 2017
Spanish (Spain) locale: s�bado, 22 22e abril 22e 2017
  (this last line appears to be bugged for some reason, possibly the online compiler is running on a system that's missing some bugfix)

The User/System Locale in the output (3rd line) is from the system that's compiling and running that code, which appears to be German.

So at the moment if the user had a non-English system, Gource would still output time as the default "C" format (the first line in the output), which is based on U.S. English.

I think the default behaviour for Gource should be to use the "" locale so it matches the user's system/profile (and have this set pretty early on when the process starts). There could optionally be a command line option to override the default locale, like --locale "en-GB", with that value passed directly to setlocale (so documentation would need to point out that locales are provided by the system, and different systems have different locale support).

from gource.