Giter VIP home page Giter VIP logo

Comments (6)

ilyes319 avatar ilyes319 commented on July 22, 2024

Hey,

Did you make sure to change also --max_ell=4 in the input file. If you do not, no l=4 spherical harmonics will be injected thus the bug.

Best,

Ilyes

from mace.

pfebrer avatar pfebrer commented on July 22, 2024

Thanks! If I increase max_ell to 4, then I get an error from e3nn:

Traceback (most recent call last):
  File "~/myenv/lib/python3.10/site-packages/e3nn/o3/_wigner.py", line 129, in wigner_3j
    out = flat_src[_W3j_indices[(l3, l2, l1)]].reshape(2 * l3 + 1, 2 * l2 + 1, 2 * l1 + 1).transpose(0, 2).mul((-1) ** (l1 + l2 + l3)).clone()
KeyError: (4, 8, 12)

During handling of the above exception, another exception occurred:
    prod = EquivariantProductBasisBlock(
  File "~/mace/modules/blocks.py", line 114, in __init__
    self.symmetric_contractions = SymmetricContraction(
  File "~/mace/modules/symmetric_contraction.py", line 71, in __init__
    self.contractions[str(irrep_out)] = Contraction(
  File "~/mace/modules/symmetric_contraction.py", line 107, in __init__
    U_matrix = U_matrix_real(
  File "~/mace/tools/cg.py", line 116, in U_matrix_real
    wigners = _wigner_nj(irrepss, normalization, filter_ir_mid, dtype)
  File "~/mace/tools/cg.py", line 55, in _wigner_nj
    C = o3.wigner_3j(ir_out.l, ir_left.l, ir.l, dtype=dtype)
  File "~/myenv/lib/python3.10/site-packages/e3nn/o3/_wigner.py", line 135, in wigner_3j
    raise NotImplementedError(f'Wigner 3j symbols maximum l implemented is {max(_W3j_indices.keys())[0]}, send us an email to ask for more')
NotImplementedError: Wigner 3j symbols maximum l implemented is 11, send us an email to ask for more

from mace.

ilyes319 avatar ilyes319 commented on July 22, 2024

Mmm yes, this should reported on e3nn repo. Usually you never need to go to that high order, it saturates at 3. Could you open an issue there and link it here?

from mace.

pfebrer avatar pfebrer commented on July 22, 2024

Ok, thanks! I would like to open an issue there, the problem is that I don't understand exactly what is going on in the _wigner_nj function, so I don't know how to explain it 😅 E.g. I don't know what order of the Wigner 3j symbols do I need.

from mace.

pfebrer avatar pfebrer commented on July 22, 2024

Forget what I said, in their latest version (e3nn==0.5.0) they already removed this restriction, and the mace model works with hidden irreps l=4 and max_ell=4 👌

from mace.

pfebrer avatar pfebrer commented on July 22, 2024

Thank you very much for the quick replies! :)

from mace.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.