make ReportsCrashes non-required about acra HOT 7 CLOSED

At this point, the @ReportsCrashes annotation is required.

What's the use case? Why don't you want to use the annotation?

William

from acra.

I several implementations for the crash reporting in my app (one for each environment). one of the implementation is ACRA. I want to keep my Application class unaware of any implementation.

from acra.

Well, I introduced the annotation as a way to ease the lib setup and configuration for beginners. It's a nice way to ensure that ACRA is initialized at the right moment, at the very beginning of the app life cycle.

Now that we added a full configuration API for advanced devs, we could make the annotation optional. But I fear that it would make troubleshooting beginners setup issues more difficult...

from acra.

For the sake of troubleshooting the log message can stay ("ACRA#init called but no ReportsCrashes annotation..."),
but if ACRA has all it needs when init() is executed, let it run. :)

Thanks.

from acra.

I also want to be able to use ACRA without the annotation.

I prefer to have the formkey in a resource or support file and not in my source code...

That would mean either a method init(Application, String formkey) or some ability of configuring prior to the init call.

On node.js, I load this kind of data from a json file provided as properties of a configuration object.

from acra.

You can configure the FormKey or any other config programatically.

Just call ACRA#setConfig(yourACRAconfiguration) before you call ACRA#init. But at present (4.4.0) you will still need to configure you Application class with the @ReportsCrashes annotation to get past the check in #init.

William

from acra.

Closing - no pull request

from acra.