Comments (8)
So if I had a class LineClamp-1250px
, how would you parse it? Seems like we need an more explicit separator between the two values.
from atomizer.
As discussed previously, the first digit in the suffix is the line-clamp
value, whatever follows is the max-height
value:
.LineClamp-1250px {
-webkit-line-clamp: 1;
max-height: 250px;
}
Yes, this suggests that authors won't be able to use a greater value than 9
for line-clamp
but I don't think there are real-life examples of clamping content to 10 lines and up. Yes, separating the 2 values would allow to use any values we want, but I'm not sure what separators we should include here so may be not worth adding complexity to cater for something that may never ever be needed.
from atomizer.
Yeah, that was my concern with the example I gave - this limits you go < 10 lines. Even if we don't feel that > 9 lines is likely, the format of that number feels really confusing and ambiguous to me...
from atomizer.
I think this is something that could be implemented as a extension coz it is not really an atomic style since it relies on several different props
from atomizer.
@3den we plan to include/offer helper/utility classes and the LineClamp-*
one is definitely one that needs Atomizer to work.
from atomizer.
@thierryk I agree, what i am suggesting is to keep the core lean and allow the community to create Atomizer extensions for helpers and make it easy for people to define their own helpers.
For instance Stencil had a lot of features on the core that very few people needed, it would be awesome for atomizer to have extra features added as "plugins" so that any one could create their own Atomic extensions without having to add that to the core #96
from atomizer.
We now have a helpers.js
ruleset that includes LineClamp
, so I believe this can be closed. @renatoi and @thierryk please confirm!
from atomizer.
Yes, we now do support LineClamp.
from atomizer.
Related Issues (20)
- RFC: New syntax for custom value string replacement HOT 8
- Use eslint instead of jshint HOT 1
- RFC: Optional specificity bump for media queries HOT 14
- add support for multiple combinators? HOT 1
- Atomizer getConfig mutates provided object, should be pure
- !important generation in atomic classes which have symbols like descendent selector (_) and Sibling selector (+) in it HOT 1
- Are there any plugin or plans to add attribute mode? HOT 1
- Landing page should be updated to show atomizer HOT 2
- Make it easier to search on right/left equivalents start/end
- Atomizer Roadmap HOT 11
- acss.io is inaccessible HOT 1
- Support space separated functions
- config: Mirror cli arguments to config
- Combine Helper atomic classes elements with others, where same set of properties & values are being used HOT 3
- Atomizer plugin not working on a vite project HOT 7
- Adding a `Mend(0):l` class breaks `Mend(0):lc` and `Mx(0)` HOT 2
- Add aspect ratio HOT 4
- Webpack atomizer-plugins: images are broken after webpack build HOT 5
- Can we have a support of "inset" CSS Property in AtomicCSS? HOT 5
- Update Remix integration to use PostCSS plugin
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from atomizer.