Giter VIP home page Giter VIP logo

Comments (1)

Jym77 avatar Jym77 commented on June 12, 2024

🤔 OK, doing a bit of digging through our (broken) Github pages deploy system.

It seems that
dispatch.yml is sending event to act-rules-web on every push on develop.
• This is taken by build.yml on the other side, which does some magic with the markdown
• Build.yml is then supposed to send back an event to the initial repo, this is apparently broken (although the curl comment does get an answer, so the workflow doesn’t fail). But some still seem to work 🤔
• This is taken on the original side by publish.yml, which is just supposed to copy everything in the master branch, used for Github pages deploy.
• Publish.yml seems broken for lack of lockfile. No recent action has succeeded. That probably explains our lack of publications on Github pages recently.

I’m not sure how well we can integrate that with deploy-pr-preview

=> It should be possible to setup a /prs/ directory (or similar) in the master branch of the main repo; then update dispatch.yml to react on any PR (not just push to develop); then on the pushback to publish.yml, we could have a payload indicating the original branch, and copy to prs/XXX instead of “.” To let Github pages do their magic (plus maybe message on the PR itself). This is manually doing what deploy-pr-preview is doing.
=> Another possibility to leverage deploy-pr-preview would be for publish.yml to create a new branch and PR with a special name, and then let deploy-pr-preview work on these PRs. That sounds needlessly complicated and doesn’t save us the hard problems of branch management and co, plus double the number of opened PRs 🙈

Given the mess that is the master branch (something to do with how Github pages are built, I guess), I don’t think it would be a good idea for each branch to contain that kind of data. I also assume the current setup was build to keep the markdown files “alone” in their repo and make it easier to understand (and avoid polluting PRs with unrelated diffs…) So I’m reluctant to do deeper changes to setup…

Since Github pages seems to de quite a lot of magic on its own, we only have to solve “simple” problems of (a) passing the correct payload back and forth (dispatch events are made for that); (b) copying to the correct directory instead of “.”; and (c) putting back a comment on the initial PR (we can probably steal from deploy-pr-preview for that, or just ignore it to start with and let the PR author or somebody else manually copy it…) Oh, and also figuring out what is making our current publish.yml unhappy and breaking the deployment.

Or maybe we could transfer ownership of the repo to the W3C org and use Netlify 🤔 I’m not sure why the ACT Rules org is separated from the W3C one… (except for allowing Github pages… which we don’t really need now that the main deploy is on the WAI site…)

from act-rules.github.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.