Comments (10)
WilcoFiers
commented on May 20, 2024
---
rule_id: SC4-1-1-accesskey
success_criterion:
- 4.1.1 # Parsing (Level A)
---
<h2>inapplicable</h2>
<div data-outcome="inapplicable">
<button accesskey="">button</button>
</div>
<div data-outcome="inapplicable">
<button>button</button>
</div>
<h2>step1-pass</h2>
<div data-outcome="passed"
data-outcome-id="step1-pass">
<button accesskey="b">button</button>
</div>
<h2>step1-fail</h2>
<div data-outcome="failed"
data-outcome-id="step1-fail">
<!-- First -->
<button accesskey="A">button</button>
</div>
<div data-outcome="failed"
data-outcome-id="step1-fail">
<!-- Second -->
<button accesskey="a">button</button>
</div>
<div data-outcome="failed"
data-outcome-id="step1-fail">
<!-- Third -->
<button accesskey="abcd">button</button>
</div>
from act-rules.github.io.
WilcoFiers
commented on May 20, 2024
---
rule_id: SC4-1-1-id
success_criterion:
- 4.1.1 # Parsing (Level A)
---
<h2>inapplicable</h2>
<div data-outcome="inapplicable">
<button>button</button>
</div>
<div data-outcome="inapplicable">
<button id="">button</button>
</div>
<h2>step1-pass</h2>
<div data-outcome="passed"
data-outcome-id="step1-pass">
<button id="unique">button</button>
</div>
<div data-outcome="passed"
data-outcome-id="step1-pass">
<!-- IDs are case sensitive -->
<button id="UNIQUE">button</button>
</div>
<h2>step1-fail</h2>
<div data-outcome="failed"
data-outcome-id="step1-fail">
<!-- First -->
<button id="not-unique">button</button>
</div>
<div data-outcome="failed"
data-outcome-id="step1-fail">
<!-- Second -->
<button id="not-unique">button</button>
</div>
<div data-outcome="failed"
data-outcome-id="step1-fail">
<!-- Third -->
<button id="not-unique">button</button>
</div>
<div data-outcome="failed"
data-outcome-id="step1-fail">
<!-- With space, not recommended, but valid -->
<button id="not unique">button</button>
</div>
<div data-outcome="failed"
data-outcome-id="step1-fail">
<!-- Second -->
<button id="not unique">button</button>
</div>
<div data-outcome="failed"
data-outcome-id="step1-fail">
<!-- Unicode! -->
<button id="☀😎🌡">button</button>
</div>
<div data-outcome="failed"
data-outcome-id="step1-fail">
<!-- Second -->
<button id="☀😎🌡">button</button>
</div>
from act-rules.github.io.
WilcoFiers
commented on May 20, 2024
---
rule_id: SC4-1-1-unique-attrs
success_criterion:
- 4.1.1 # Parsing (Level A)
---
<h2>inapplicable</h2>
<div data-outcome="inapplicable">
<button>button</button>
</div>
<h2>step1-pass</h2>
<div data-outcome="passed"
data-outcome-id="step1-pass">
<button type="submit">button</button>
</div>
<h2>step1-fail</h2>
<div data-outcome="failed"
data-outcome-id="step1-fail">
<button type="submit" type="submit">button</button>
</div>
<div data-outcome="failed"
data-outcome-id="step1-fail">
<button type="submit" type="reset">button</button>
</div>
<div data-outcome="failed"
data-outcome-id="step1-fail">
<button disabled disabled>button</button>
</div>
from act-rules.github.io.
EmmaJP
commented on May 20, 2024
Thanks. Good to know the format.
Presume each is a complete block of code the test is run against as a whole, with meta-data for comparison on the <div> and elements that the test will check inside each <div>.
Presume data outcome should be "incomplete" with a t ... corrected. Seems OK for an empty attribute but an odd outcome for inapplicable code with no attribute to check.
Accesskeys ... should inapplicable include <button>button<button>?
...
Also, I think these draft rules might still need #62 applied.
from act-rules.github.io.
WilcoFiers
commented on May 20, 2024
Presume each is a complete block of code the test is run against as a whole, with meta-data for comparison on the
<div>and elements that the test will check inside each<div>.
Yep
Presume data outcome should be "incomplete" with a t ... corrected. Seems OK for an empty attribute but an odd outcome for inapplicable code with no attribute to check.
I'm not sure I understand. Can you clarify?
Accesskeys ... should inapplicable include button?
Why not? Accesskeys only make sense on an interactive element.
Also, I think these draft rules might still need #62 applied.
Yes
from act-rules.github.io.
EmmaJP
commented on May 20, 2024
The suggestion for accesskeys is:
<h2>inapplicable</h2>
<div data-outcome="incomplete">
<button accesskey="">button</button>
</div>
It seems to be missing (compared to the other two code blocks above):
<div data-outcome="incomplete">
<button>button</button>
</div>
Comparing accesskeys and id ... either accesskeys should include the no-accesskeys scenario, or id should not include it.
from act-rules.github.io.
EmmaJP
commented on May 20, 2024
Presume data outcome should be "incomplete" with a t ... corrected. Seems OK for an empty attribute but an odd outcome for inapplicable code with no attribute to check.I'm not sure I understand. Can you clarify?
Incomplete was spelt "incomplee" a couple of times, I already edited the comments to correct it.
The word "incomplete" seems an appropriate outcome when something being checked is empty or missing something (eg. id=""). However, it feels incongruous for the situation where a rule does not apply (eg. a set of elements with zero id attributes), where "inapplicable" might suit better.
They may seem similar, but are not quite the same.
from act-rules.github.io.
WilcoFiers
commented on May 20, 2024
Agreed. I'm updating them now. Do you want me to put together a PR?
from act-rules.github.io.
EmmaJP
commented on May 20, 2024
https://www.w3.org/TR/2014/NOTE-WCAG20-TECHS-20140311/F17 has been dropped from WCAG, so there no longer needs to be a check for duplicate accesskey values.
https://auto-wcag.github.io/auto-wcag/rules/SC4-1-1-unique-id.html has already been updated.
So only unique attributes needs a rule rewritten.
from act-rules.github.io.
EmmaJP
commented on May 20, 2024
from act-rules.github.io.
Related Issues (20)
- Deprecated rule [9eb3f6] HOT 1
- "Image accessible name is descriptive" is a bad title
- Rule idea: video element avoids automatically playing moving content HOT 2
- Audio or video element avoids automatically playing audio: passed example 2 should be inapplicable
- Rule idea: ARIA required accessible names
- Title descriptive expectation is vague[c4a8a4] HOT 2
- Should `<input type="password">` be considered as form field? HOT 2
- Confusion about how "assigned" headings work with ARIA [d0f69e] HOT 3
- "Text contrast" [afw4f7, 09o5cg]: Should rule apply to `X` for close? HOT 4
- [tooling]: Add test to check that each rule has a unique `id`
- Required states can come from native elements [4e8ab6] HOT 1
- Should rules have an assumption about aria-busy? HOT 1
- Deprecate old website and redirect to WAI website HOT 1
- image of text: clarify why pictures, but not all images with text and other significant content are exempt [0va7u6]
- Inapplicable examples should be failed if considered applicable (at least ff89c9) HOT 1
- [chore] Check for missing links (definition) in Glossary HOT 1
- [chore] Update ARIA 1.1 links HOT 1
- Add a test for missing squar-bracket links HOT 1
- meta-refresh rules, add explanation of meta element [bisz58] [bc659a]
- Clarify that "Image resource" can be any supported image format [0va7u6]
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from act-rules.github.io.