Comments (2)
Hi @andreas-borglin - that's correct, this action only reviews diffs between commits to the default branch, because it also relies on data that's only in the dependency graph for the repo, which is only created for the default branch.
Thanks for using the action!
from dependency-review-action.
Hi again.
Sorry but this doesn't seem quite right to me. The dependency submission API allows for dependency information to be submitted for any git reference, and from that, the dependency review API can then be used to get a diff of the dependencies between any two submitted snapshots associated with any git refs in the repo. This is described in the GitHub docs and can be easily verified via the APIs. There is no dependency on the default branch for the APIs.
This action uses the latter API as per https://github.com/actions/dependency-review-action/blob/main/src/dependency-graph.ts#L28-L35.
Hence, if dependency snapshots have been submitted via the dependency submission API for any target branch, and for any source branch with a PR targeting the target branch, then this action does work as expected. We have tested this action fairly extensively now with non-default branches and it works as we'd expect.
But yes, if the dependency submission API is not used, then this would only work against the default branch as that is the only branch that is reported to the graph automatically via dependabot. However the README does not make this clear.
Thanks, Andreas
from dependency-review-action.
Related Issues (20)
- Deny Packages Icon should be Red X (not a yellow warning) HOT 3
- Feature Request: Block on unknown licenses HOT 1
- `warn_only` Does Not Apply When Using a Deny List HOT 1
- error "fetch failed" with v4.2.5 HOT 3
- Scorecard table URLs include duplicate https:// HOT 3
- MIT is an invalid SPDX license identifier? HOT 2
- Conflict between vulnerabilities in scorecard vs check
- v4.3.0 Causing PURL Processing Errors HOT 6
- Allow this action to run on branch HOT 4
- Latest release breaks dependabot HOT 3
- Configuring allow-dependencies-licenses fails the action HOT 3
- Error :- Purl String argument is required . HOT 4
- Adding a license in 'allow-dependencies-licenses' does not prevent it from being populated in "invalid-license-changes" HOT 6
- Job Summary Size Limitation aborts the job HOT 2
- `fail-on-severity` should still show lower severity vulnerabilities
- [BUG] When the report exceeds 64KB pr issue is not created since it exceeds max comment issue HOT 1
- Why is this not named `dependency-review` HOT 1
- Job Summary Size Limitation aborts the job [BUG] HOT 2
- [BUG] Release 4.3.4 breaking change with SPDX expressions HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dependency-review-action.