Giter VIP home page Giter VIP logo

Comments (4)

MaksimZhukov avatar MaksimZhukov commented on July 18, 2024 1

Hello @alexandre-combemorel!
Yes, you are right, as described in the README ALL listed globs in any selector have to match against ANY changed path. The following configuration

home:
- apps/home/*
- apps/home/**/*
- apps/middleware/*
- apps/middleware/**/*

is not equivalent to

home:
- any: ["apps/home/*", "apps/home/**/*", "apps/middleware/*", "apps/middleware/**/*"]

It is equivalent to

home:
- any: ['apps/home/*']
- any: ['apps/home/**/*']
- any: ['apps/middleware/*']
- any: ['apps/middleware/**/*']

If you want to apply a label if one of listed paths matches, you should use the config structure that you attached in the issue description. Does it make sense to you?

from labeler.

marko-zivic-93 avatar marko-zivic-93 commented on July 18, 2024

Hello @alexandre-combemorel
Thank you for bringing our attention to this issue. We will investigate it and come back to you as soon as we have some news 🙂

from labeler.

alexandre-combemorel avatar alexandre-combemorel commented on July 18, 2024

Hi @marko-zivic-93, should I open a PR with the fix I suggested?

from labeler.

alexandre-combemorel avatar alexandre-combemorel commented on July 18, 2024

Sorry for the very late response, Ok I understand now, I got confused in the README as the example stands on 1 path only and it shows equivalent configuration.
It might be worth to add a second path to give more context?

But thank you for pointing out, it seems our CI is working correctly now.

from labeler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.