Comments (8)
I observe the same issue. Specifically, with v4.1.0, a change in a top-level README.md
is not picked up; with v4.0.4, it is (for the configuration shown above). Maybe regression introduced by the dot
feature?
In this PR, I switch between v4.0.4 and v4.1.0 with sync-labels: true
and a change only in the top-level README.md
; with v4.1.0, the label is removed, with v4.0.4, it is applied.
from labeler.
@alebaffa, I have investigated the PR you mentioned. Action works just fine, the issue in the PR is using
/
in the beginning of the blob/**/*.md
. If you change it to**/*.md
- it works as expected.cc @bewuethr
I thought "that's not right" and started more reproducers, based on this config:
name: Labeler
on:
- pull_request_target
jobs:
label:
runs-on: ubuntu-22.04
permissions:
contents: read
pull-requests: write
steps:
- uses: actions/[email protected]
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
Then I did this:
- https://github.com/bewuethr/github-actions-tests/pull/3
- https://github.com/bewuethr/github-actions-tests/pull/4
- Update config to v4.1.0
- https://github.com/bewuethr/github-actions-tests/pull/5
- https://github.com/bewuethr/github-actions-tests/pull/6
aaaand they all work as expected, so that simple reproducer is wrong.
I definitely noticed a disparity between v4.1.0 and v4.0.4 with sync-labels: true
, trying to reproduce here:
- Enabled
sync-labels: true
- Opened PR that touched top-level README: https://github.com/bewuethr/github-actions-tests/pull/7
- Switched back to v4.0.4
- Switched back to 4.1.0
... but that also all behaved correctly.
The only weird thing I ever observed was in this PR, where switching between v4.0.4 and v4.1.0 would add and remove the label:
But I haven't been able to reproduce this π€·π»ββοΈ
from labeler.
Just saw #526 . Probably it's the same issue? Though, this case is also mentioned in the examples in the documentation..not sure..
from labeler.
Hello, @alebaffa! I hope this message finds you well.
Firstly, thank you for bringing this issue to our attention. I've been attempting to reproduce the error based on the information you've provided, however, so far I've been unable to replicate the same behavior.
To better understand the problem and provide a solution, it would be extremely helpful if you could provide a link to the specific GitHub Actions run where you experienced the failure. This will help us to pinpoint the exact circumstances under which the issue is occurring and expedite the process of finding a resolution.
Thank you in advance for your time and assistance. Your contribution to improving our project is highly valued.
Best regards.
from labeler.
I think the comment by @bewuethr, and his PR, describes the issue and how to replicate it more clearly than what I wrote. I then tested so many other things, delete branches and merged PRs that now it's difficult to give you something replicable from my repo.
Basically, as bewuethr tested, I am just following the examples given in the documentation with the latest release and the label is not applied. Looks like v4.1.0 introduced a regression. It is working with v.4.0.4.
from labeler.
@alebaffa, I have investigated the PR you mentioned. Action works just fine, the issue in the PR is using /
in the beginning of the blob /**/*.md
. If you change it to **/*.md
- it works as expected.
cc @bewuethr
from labeler.
@bewuethr, thanks for your efforts in reproducing the issue, much appreciated!
@alebaffa, are you still experiencing any difficulties regarding the topic? Is there anything I could help you with?
from labeler.
Thank you both for your help. I am going to close this issue.
from labeler.
Related Issues (20)
- Sync-labels should not remove an unspecified label HOT 2
- Error when configuration is invalid HOT 1
- Branch name checks ignored as top level key HOT 2
- example fails yaml validation HOT 7
- Char HOT 1
- Node 16 gets warning HOT 2
- Description seems dangerous HOT 5
- Labeler should never remove labels it has not configured HOT 5
- Add a label to the PR if the review has ended with a request to make changes HOT 1
- Could not find pull request warning for pull_request closed event HOT 2
- Is it possible to label based on number of lines changed? HOT 1
- Update documentation to note that you can use sentences in labels HOT 1
- Allow for only applying a label if another label has not been applied (enumerated labels) HOT 1
- Merging `main` into PR causes incorrect labeling HOT 2
- Apply label only if it's the only change to the document HOT 1
- Hoy por mi maΓ±ana por ti HOT 1
- Very slow when many files match filter HOT 1
- Label PR coming from other repository using workflow-dispatch HOT 2
- Conditionally exclusive labels HOT 1
- Having difficulty creating my globs HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from labeler.