Giter VIP home page Giter VIP logo

Comments (7)

dymanoid avatar dymanoid commented on July 23, 2024 2

After discussing on Discord, this what we decided to implement:
image

from actual.

dymanoid avatar dymanoid commented on July 23, 2024

Will be happy to work on this. Please also see my comment in #2774.

from actual.

youngcw avatar youngcw commented on July 23, 2024

I think that the a better solution would be to somehow integrate the arrow into the pill around the value. Maybe the pill should run up against the side of the screen and then the arrow can be inside the pill along with the amount

from actual.

dymanoid avatar dymanoid commented on July 23, 2024

Here are three possible solutions. Which one do you prefer?
I don't like the 3rd one where the dark value containers extend to the right to cover the carryover arrow.
I personally prefer the 1st one where the arrows are outside of the value containers, so basically the current design. But the 2nd one is also okay.
So what are your thoughts?
Variant 1:
a1

Variant 2:
a2

Variant 3:
a3

from actual.

youngcw avatar youngcw commented on July 23, 2024

@dymanoid
option 1 would match desktop the most and is the most similar to existing. I wouldn't be against option 2 though if others liked that more.

With option 3 could the pill be squared against the side? So no rounded right side.
that might make it feel less inconsistent.

from actual.

dymanoid avatar dymanoid commented on July 23, 2024

Something like this?

image

from actual.

youngcw avatar youngcw commented on July 23, 2024

@dymanoid Yeah that was what I was thinking. It still seems a bit weird, but its an option. My hope is that we don't have to lose more space just to make it look good if possible. That extended pill could maybe do that and maybe different enough from the regular pill to not look wrong or missaligned

from actual.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.