Giter VIP home page Giter VIP logo

Comments (7)

youngcw avatar youngcw commented on July 4, 2024 1

I don't have any issue with parents of splits being included in the select all, as long as the selected total is calculated right.

For the schedules, I don't think those should be considered transactions since they have yet to be added. They are in the table for reference purposes. Also, the bulk options are different for schedules than for regular transactions.

from actual.

MatissJanis avatar MatissJanis commented on July 4, 2024

Looks like it doesn't select split-transaction parent transactions either.

Screenshot 2024-06-16 at 21 05 07

from actual.

youngcw avatar youngcw commented on July 4, 2024

This feels like the correct behavior to me. Schedules are different than regular transactions and if the split parent is included in the selection the amount calculations get messed up.

from actual.

MatissJanis avatar MatissJanis commented on July 4, 2024

Interesting perspective. From a usability POV I would expect a "select all" checkbox in the header to do what most other products do - to select all the entries within the table. Is there a good argument for why we should treat schedules differently?

if the split parent is included in the selection the amount calculations get messed up

IMO this is an unrelated problem. Even if you manually select the parent + children transactions - the calculations get messed up. It definitely should be addressed. But it's not really related to select-all functionality.

from actual.

dangrous avatar dangrous commented on July 4, 2024

To be honest, I would lean towards @youngcw's perspective that - for me - this is the ideal behavior (I never want to include non-current stuff) but, I think overall I'd agree that select all should do what it says on the tin and select all. It'd definitely be worth thinking about some sort of "select real entries" though too in the future!

from actual.

joel-jeremy avatar joel-jeremy commented on July 4, 2024

I would then to agree that the parent should not be selected specially with the recent change where the parent transaction is just going to be a shell of its children transactions (no payee, no category)

from actual.

dangrous avatar dangrous commented on July 4, 2024

So it sounds like the current behavior is the expected one then?

I feel like it looks a little weird to have the parents not selected, but it makes more sense that way. Maybe there's a visual cue if all child transactions are selected vs. not - that would be a separate issue though.

from actual.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.