Giter VIP home page Giter VIP logo

Comments (16)

matt-fidd avatar matt-fidd commented on August 15, 2024 1

Thank you!

That looks to have done the trick, I'm just using a blank file with 24 transactions, that seems to be the right amount to fill my page.

from actual.

MatissJanis avatar MatissJanis commented on August 15, 2024

Are you able to reproduce this on https://demo.actualbudget.org (latest tagged release)?

from actual.

matt-fidd avatar matt-fidd commented on August 15, 2024

This is not reproducable on demo.

I've worked out what the trigger is. When there are too many transactions to fit on a single page the scroll bar appears. It looks like there must be a very niche edge case where it's just on the verge of needing the scroll bar, and so flicks between adding and removing it.

To reproduce:

  • Add just enough transactions to a blank account that one more will trigger the scroll bar
  • Add one more
  • If the screen size is just right (I imagine this is a very small window because it's only occured in a very specific environment for me) then the table will add and remove the scrollbar in a loop
  • Adding or removing a single transaction will stop this from occuring.

Edge:
https://github.com/actualbudget/actual/assets/81489167/e758d50d-bfff-435c-8b14-a9e4418a28e7

Demo:
https://github.com/actualbudget/actual/assets/81489167/cb5572a3-7a6d-4794-9550-3d2afb5cb70c

from actual.

MatissJanis avatar MatissJanis commented on August 15, 2024

Possible root cause: #2867

from actual.

matt-fidd avatar matt-fidd commented on August 15, 2024

Let me try reverting that PR and seeing if it persists, the 200ms cycle would make sense

from actual.

matt-fidd avatar matt-fidd commented on August 15, 2024

Possible root cause: #2867

You're dead on, reverting the commit fixed the bug

from actual.

MatissJanis avatar MatissJanis commented on August 15, 2024

cc @lelemm FYI

from actual.

lelemm avatar lelemm commented on August 15, 2024

omg. I will try to reproduce it

from actual.

lelemm avatar lelemm commented on August 15, 2024

@matt-fidd can you tell me what resolution are you using on that machine and scale size?

from actual.

matt-fidd avatar matt-fidd commented on August 15, 2024

Looks to be a viewport of 1920 x 937 but I can't seem to reproduce it outside of my work remote desktop, even with the same viewport size.

from actual.

matt-fidd avatar matt-fidd commented on August 15, 2024

Aha! It's tied to the Chrome version, not so much the viewport.

I just tested in Chromium 1070081 and could reproduce it easily.

Official build for Windows:
https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Win/1070081/

Similar version for Mac but I can't test
https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Mac/1070019/

from actual.

lelemm avatar lelemm commented on August 15, 2024

nice, I will download it to test out

from actual.

lelemm avatar lelemm commented on August 15, 2024

tried to replicate, no success yet. Tried with demo and my own budget

from actual.

lelemm avatar lelemm commented on August 15, 2024

Ok, I was able to reproduce it now.
The cause of this is the fact that the number of lines in the grid is size of the screen, so the app keeps adding the scrollbar and removing it.

from actual.

lelemm avatar lelemm commented on August 15, 2024

Try this https://deploy-preview-2941.demo.actualbudget.org/ @matt-fidd
I was able to use the demo budget. You have to delete transactions from an account to fill the screen like this:
image

from actual.

lelemm avatar lelemm commented on August 15, 2024

Nice @matt-fidd ! good news! :)

@MatissJanis can you review the PR? merge is frozen atm too

from actual.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.