GetUsage<T>() fails when called from unit test about powerargs HOT 7 CLOSED

GetUsage has an overload that takes a string parameter that is the exe name. When you use the overload it doesn't try to get the assembly location automatically. You should use this in unit tests. I do it in the unit tests for the product itself.

from powerargs.

Right. Should have thought of that. Thanks. Will do.

from powerargs.

Thought about this some more:

Though you've provided a reasonable work-around which solves my current problem, I still believe that the fact that your library throws a null reference exception when used "correctly" is a bug. And by "correctly", I mean used in a way that your application support such as calling GetUsage() with no parameter.

Since GetEntryAssembly() is documented to return null under certain situations, you should be checking for null before dereferencing.

So I still believe this is a bug.

from powerargs.

Codatrix,

I agree with you, however I also think that this is opensource software and for us to embrace it means to fork it an apply the fix and ask for a pull request.

Adam would appreciate the help :)

from powerargs.

I'll see if I can find the time to do that. Thanks! :-)

from powerargs.

Thanks for the collaboration. It's a pretty small change. I'm thinking something like this:

        if (exeName == null)
        {
            var assembly = Assembly.GetEntryAssembly();
            if (assembly == null) throw new ArgException("PowerArgs could not determine the name of your executable automatically.  This may happen if you run GetUsage<T>() from within unit tests.  Use GetUsageT>(string exeName) in unit tests to avoid this exception.");
            exeName = Path.GetFileNameWithoutExtension(assembly.Location);
        }

Will that suit your needs?

Thanks,
Adam

from powerargs.

Fixed

from powerargs.