Giter VIP home page Giter VIP logo

Comments (19)

samwainwright avatar samwainwright commented on May 27, 2024 2

@AdamXweb that works! Looking forward to seeing the new release and the full style guide. For now I'm happy to have the wonky tab title:
image

from whitesurfirefoxthememacos.

FraserEmbrey avatar FraserEmbrey commented on May 27, 2024 1

Thanks so much, it's not quite centred for me: I tried

.tab-content:not([pinned])::before,
.tab-content:not([pinned])::after{
    display: -moz-box;
    content: "";
    -moz-box-flex: 2
}
.tab-content:not([pinned])::after {
    -moz-box-flex: 1;
}

And it seems better

from whitesurfirefoxthememacos.

samwainwright avatar samwainwright commented on May 27, 2024 1

Thanks to everyone who's contributed on this! I need to be careful what I wish for as I'm now struggling to tell Firefox and Safari apart! 😂

from whitesurfirefoxthememacos.

AdamXweb avatar AdamXweb commented on May 27, 2024 1

Give it another go, should be fixed now!

from whitesurfirefoxthememacos.

AdamXweb avatar AdamXweb commented on May 27, 2024

Would be interesting!
I'd like to implement it as an option during the install phase, as I feel locations of buttons can come down to user preference, even though the theme is mostly based on safari.

from whitesurfirefoxthememacos.

AdamXweb avatar AdamXweb commented on May 27, 2024

I'll reference this link to read into it further later on..
https://www.reddit.com/r/FirefoxCSS/comments/muuad2/moving_close_button_to_right/

from whitesurfirefoxthememacos.

FraserEmbrey avatar FraserEmbrey commented on May 27, 2024

I'd like to add +1 to requests for this issue, or at least put how to swap it into the readme.
Trying the typical ways to do this doesn't seem to work with this theme.

from whitesurfirefoxthememacos.

Parthvsquare avatar Parthvsquare commented on May 27, 2024

i too would like this feature to see the daylight. count me in

from whitesurfirefoxthememacos.

AdamXweb avatar AdamXweb commented on May 27, 2024

So this is a work in progress, but if you want to try it out without the styling changes, you can test the following:

/* Place close button on left side */
.tab-content {
	display: -moz-box !important;
}
.tab-close-button {
	-moz-box-ordinal-group: 0
}

I'll be releasing within the week with better styling and guides to implement it

from whitesurfirefoxthememacos.

Parthvsquare avatar Parthvsquare commented on May 27, 2024

I foolishly tried adding padding-right: 2px; It didn't work. But i am happy with the result. Thanks man.
The result
image

from whitesurfirefoxthememacos.

FraserEmbrey avatar FraserEmbrey commented on May 27, 2024

I foolishly tried adding padding-right: 2px; It didn't work. But i am happy with the result. Thanks man.
The result
image

How did you get it centred?

Thanks @AdamXweb for the test styling. Before I had the close in the right place but the title was on the far right.

from whitesurfirefoxthememacos.

Parthvsquare avatar Parthvsquare commented on May 27, 2024

I foolishly tried adding padding-right: 2px; It didn't work. But i am happy with the result. Thanks man.
The result
image

How did you get it centred?

Thanks @AdamXweb for the test styling. Before I had the close in the right place but the title was on the far right.

/* to change close button position */
.tab-content {
	display: -moz-box !important;
}

.tab-close-button{ -moz-box-ordinal-group: 0 }
.tabbrowser-tab .tab-close-button{ visibility: hidden; }
.tabbrowser-tab:not([pinned]):hover .tab-close-button{ visibility: visible !important }
.tab-content:not([pinned])::before,
.tab-content:not([pinned])::after{ display: -moz-box; content: ""; -moz-box-flex: 1 }

i don't know which class is working

from whitesurfirefoxthememacos.

AdamXweb avatar AdamXweb commented on May 27, 2024

An install option is now available with the flag -c to add the close button on the left hand side.

from whitesurfirefoxthememacos.

AdamXweb avatar AdamXweb commented on May 27, 2024

Screen Shot 2021-05-17 at 8 28 53 pm

from whitesurfirefoxthememacos.

FraserEmbrey avatar FraserEmbrey commented on May 27, 2024

Having an issue:
Says option requires an argument -- c

Screenshot 2021-05-17 at 11 38 17

This was on master branch as in the above screenshot

from whitesurfirefoxthememacos.

AdamXweb avatar AdamXweb commented on May 27, 2024

Having an issue:

Says option requires an argument -- c

Screenshot 2021-05-17 at 11 38 17

This was on master branch as in the above screenshot

What OS are you using?

from whitesurfirefoxthememacos.

FraserEmbrey avatar FraserEmbrey commented on May 27, 2024

macOS 11.3.1

I tried with the built in bash (3.5) and a recent (5.1.8) version.

If I pass the argument 1, it works as expected. Unsure why it wants an argument.

from whitesurfirefoxthememacos.

FraserEmbrey avatar FraserEmbrey commented on May 27, 2024

It does work now, thanks so much!

Sorry I wasn't any help, I don't really use getopts (sometimes use args in fish but that's about it).

from whitesurfirefoxthememacos.

AdamXweb avatar AdamXweb commented on May 27, 2024

It does work now, thanks so much!

Sorry I wasn't any help, I don't really use getopts (sometimes use args in fish but that's about it).

Not a problem!
I'd appreciate a star if you found the theme useful :)

from whitesurfirefoxthememacos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.