Giter VIP home page Giter VIP logo

Comments (4)

n1k0 avatar n1k0 commented on July 17, 2024

I was wondering nearly the same reading the mentioned conversation, so a big +1 for a Macro system refactoring. At the time I wrote it, I didn't expect landslide to become what it is now ;)

I like very much the refactoring approach you describe, so you got a big +1 here. My only concerns is backward compatibility and QA, so we should ensure to have sufficient tests to ensure we won't break everything for existing presentations :)

from landslide.

adamzap avatar adamzap commented on July 17, 2024

I like this idea as well. I just merged BestFriendChris' presenter view branch, and now I'll be working on the new macro system.

How should we go about including new macros into the rendering of a slideshow? If there's not much overhead, we may as well parse for every macro landslide has (QR codes and all). I do not want a user of landslide to have to touch to the code to enable a macro we ship with.

n1k0, we talked about about not including the QR macro as default...as we rethink the macro system, how should the user enable it? Or do you also think it should be enabled automatically?

from landslide.

BestFriendChris avatar BestFriendChris commented on July 17, 2024

I think there are 2 things we could do related to choosing macros:

  • Move all the optional macros (like QR) to the themes directory (as per issue #45). If you don't what a particular macro, you could just make your own theme.
  • Add another setting to the config file that is a list of macro files to load.

Either one would also solve the other goal I have: be able to write new macros without having to commit to the landslide codebase

from landslide.

n1k0 avatar n1k0 commented on July 17, 2024

The more I think about landslide the more I can't imaging working with it without a config file. Adding a new setting with the list of macro to load would just be the way to go imho, while I can't really imagine passing the macro names in some command line option…

Last, +1000 for allowing the use of any macro which comply to the standard interface, wherever they are.

from landslide.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.