Giter VIP home page Giter VIP logo

Comments (9)

frencojobs avatar frencojobs commented on May 31, 2024 1

What the OP suggests is valid. The dialog widget seems not that flexible in ways such that I can't get full control of the dialog contents. For instance, I can't change the text style of the dialog content texts, or at least I can't find a way to do that. So to add more parameters to the existing dialogConfig interface or to leave that dialog part completely to the user seems like a better idea. And I prefer the second one.

from pin_code_fields.

adar2378 avatar adar2378 commented on May 31, 2024

I've consulted with a UX designer before making decision on UI. The pasted code should be asked from the user.
And there are these parameters which solve the localization problem
`/// title of the [AlertDialog] while pasting the code. Default to [Paste Code]
final String dialogTitle;

/// content of the [AlertDialog] while pasting the code. Default to ["Do you want to paste this code "]
final String dialogContent;

/// Affirmative action text for the [AlertDialog]. Default to "Paste"
final String affirmativeText;

/// Negative action text for the [AlertDialog]. Default to "Cancel"
final String negativeText;`

from pin_code_fields.

adar2378 avatar adar2378 commented on May 31, 2024

Did you mean the localization for the pasted value?

from pin_code_fields.

SF-Simon avatar SF-Simon commented on May 31, 2024

from pin_code_fields.

adar2378 avatar adar2378 commented on May 31, 2024

In that case, there must be a default one, as developers might not have the time to add their own dialog widget, they just want to use a default one. Or if someone wants to modify then they can their own, but there should be a default one always.

from pin_code_fields.

adar2378 avatar adar2378 commented on May 31, 2024

Thanks for your feedback, there should always be a default configuration which would automatically generate default dialogs and stuffs for user as many developers might not the need customization. And for the one who needs customization, how would you suggest it to be? Should they be able to able to change content only or they can build the whole widget with other buttons and stuffs?

from pin_code_fields.

frencojobs avatar frencojobs commented on May 31, 2024

It's all up to you. If you don't want to remove the current implementation of the dialog widget and API, because it seems like a good idea since many users might not need customization, then please don't as it's a good and valid reason. I just suggested to leave it completely to the user (maybe as an event listener as the OP implied) because that dialog part seems like not a part of the library. If you don't want to remove it, then leaving the whole building process of the dialog might not be a good idea. The two seem really diverse.

Whether you add more configurations to the dialogConfig or leaving the whole process as an event, either one should work.

from pin_code_fields.

brenoasm avatar brenoasm commented on May 31, 2024

No updates on this?

from pin_code_fields.

stale avatar stale commented on May 31, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from pin_code_fields.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.