Giter VIP home page Giter VIP logo

Comments (6)

Mizzick avatar Mizzick commented on June 27, 2024

Ok, and what it displays now for Blocked+Whitelisted?

What do you mean under Blocked+Whitelisted?
I see two possible options: "Blocked OR Whitelisted" or "Blocked AND Whitelisted". The "AND" option seems to be more correct in this case.

from adguardbrowserextension.

Alex-302 avatar Alex-302 commented on June 27, 2024

Now if selected Blocked and Whitelisted, the list is empty.

I mean "Blocked AND Whitelisted". Sometimes it is useful to see only blocked and whitelisted simultaneously.

from adguardbrowserextension.

ameshkov avatar ameshkov commented on June 27, 2024

@Mizzick why so?

You would be right if we had radio buttons there.
But checkboxes group usually means OR, not AND.

from adguardbrowserextension.

Mizzick avatar Mizzick commented on June 27, 2024

Actually I think checkboxes list in filters means AND. But in our case it seems to be more possible an UI mistake.
I will show you something:
show &= !this.searchWhitelisted || (filterData.requestRule && filterData.requestRule.whiteListRule);
show &= !this.searchBlocked || (filterData.requestRule && !filterData.requestRule.whiteListRule);

So Blocked OR Whitelisted will just show all items.

from adguardbrowserextension.

ameshkov avatar ameshkov commented on June 27, 2024

Actually I think checkboxes list in filters means AND.

That's what we are talking about. Currently checkboxes means AND, but by UX guidelines checkboxes should mean OR.

So Blocked OR Whitelisted will just show all items.

It is really not that hard to make it work properly instead.

from adguardbrowserextension.

Mizzick avatar Mizzick commented on June 27, 2024

Fixed

from adguardbrowserextension.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.