Comments (6)
Ok, and what it displays now for Blocked+Whitelisted?
What do you mean under Blocked+Whitelisted?
I see two possible options: "Blocked OR Whitelisted" or "Blocked AND Whitelisted". The "AND" option seems to be more correct in this case.
from adguardbrowserextension.
Now if selected Blocked and Whitelisted, the list is empty.
I mean "Blocked AND Whitelisted". Sometimes it is useful to see only blocked and whitelisted simultaneously.
from adguardbrowserextension.
@Mizzick why so?
You would be right if we had radio buttons there.
But checkboxes group usually means OR, not AND.
from adguardbrowserextension.
Actually I think checkboxes list in filters means AND. But in our case it seems to be more possible an UI mistake.
I will show you something:
show &= !this.searchWhitelisted || (filterData.requestRule && filterData.requestRule.whiteListRule);
show &= !this.searchBlocked || (filterData.requestRule && !filterData.requestRule.whiteListRule);
So Blocked OR Whitelisted will just show all items.
from adguardbrowserextension.
Actually I think checkboxes list in filters means AND.
That's what we are talking about. Currently checkboxes means AND, but by UX guidelines checkboxes should mean OR.
So Blocked OR Whitelisted will just show all items.
It is really not that hard to make it work properly instead.
from adguardbrowserextension.
Fixed
from adguardbrowserextension.
Related Issues (20)
- EasyList Popup Issue
- Injects on pikabu.ru don't work correctly and rules may not apply
- The filtering in Edge's split screen doesn't work
- Buttons in AdGuard filtering log are offset from the button text in Opera
- Adguard filtering log in Opera does not show requests when visiting search engines (Google, Bing, Duckduckgo) HOT 3
- Issue: "Dandelion Sprout's Annoyances List" Blocks All Video Thumbnails on YouTube Channel Pages HOT 1
- blocked but rendered
- Auto pause AdGuard Chrome Plugin when connected to specific WiFi or LAN HOT 1
- Audio ads are not blocked HOT 1
- ya.ru - `Hide Referrer from third parties` breaks the site
- [Firefox for Android] Fix Uninstall page opening on mobile Firefox browser
- The filtering log displays requests in the wrong tab
- Youtube shows ads after all HOT 2
- é误ćŚćŞ HOT 1
- HDFC portal issue with adguard browser extention enabled [ticket# 916920] HOT 2
- Youtube ad issue HOT 1
- Not private
- Youtube Ad Issue
- localhost HOT 1
- Adguard test page not working in linux
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
đ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. đđđ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google â¤ď¸ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from adguardbrowserextension.