Experimental Filter causing redirections when updated in uBO about filtersregistry HOT 18 CLOSED

No the cause is uBO wasn't prepared to deal with multiple !#include sub-lists failing to be fetched. In the current case I see three sublists which fetch operation result in error. I will push a fix soon.

from filtersregistry.

Happened again

Did you customized some advanced settings?

Yes, most of them.

from filtersregistry.

We are testing !#include and !#if filters directives and these should be gone soon.

from filtersregistry.

Why is it only happening to the Experimental Filter though ?

from filtersregistry.

@uBlock-user we added these new directives to the Experimental filter (as per name:) ):
https://github.com/AdguardTeam/AdguardFilters/blob/master/ExperimentalFilter/sections/Other/filter.txt

from filtersregistry.

I hope you remove it soon, I had to remove the filter as it no longer updates and causing an endless loop of redirections.

from filtersregistry.

Yeah, it will be removed in a couple of hours, we're almost finished.

I hope you remove it soon, I had to remove the filter as it no longer updates and causing an endless loop of redirections.

Too bad, this looks like a uBO bug to me.

@gorhill take a look plz. !#include pointing to a non-existing file seems to be messing with uBO.

• File: https://filters.adtidy.org/extension/ublock/filters/5.txt
• Includes https://filters.adtidy.org/extension/ublock/filters/windows.txt (404)
• Causes an infinite loop

from filtersregistry.

Same issue occurs if I add https://filters.adtidy.org/extension/chromium/filters/5.txt FYI

from filtersregistry.

pointing to a non-existing file seems to be messing with uBO

I am not seeing this on my side, error was detected and loading was aborted. uBO will consider the fetch to have errored if one of the 3 following conditions is fulfilled:

• Status code is outside the 200-299 range; OR
• No data in the response body; OR
• First and last character of trimmed response body is < and >.

In the current case, the first condition was hit (404).

from filtersregistry.

What about the endless loop ? It tries, gets redirected, fails and then tries again repeatedly.

from filtersregistry.

What about the endless loop ?

As said, I am not seeing an endless loop. If you see this it means one of the 3 mentioned conditions was not met. uBO does not "retry" a failed fetch, there is no code in uBO to do so, it aborts when it detects one.

from filtersregistry.

What about the endless loop ? It tries, gets redirected, fails and then tries again repeatedly.

We are observing it on the server side: something is constantly hitting the rate limit. Rate limited requests look like they're from ubo (random ?_= parameter).

from filtersregistry.

As said, I am not seeing an endless loop.

It does take a break of few secs approximately before trying again. I will post a new logger output.

Edit - Nvm, I can't reproduce it anymore.

from filtersregistry.

@ameshkov You say you also experience an infinite loop -- I am unable to reproduce this. This is where uBO starts the fetching of a list and where it handles include directives:

https://github.com/gorhill/uBlock/blob/master/src/js/assets.js#L227

This is called only for when a list is fetched (when auto update kicks in or when clicking "Update now" button), i.e. never repeatedly.

from filtersregistry.

It does take a break of few secs approximately before trying again

Did you customized some advanced settings?

from filtersregistry.

and again(larger output)

Keep chrome-extension://cgbcahbpdhpcegmbfconppldiemgcoii/dashboard.html#3p-filters.html opened along with the logger and it will gather.

from filtersregistry.

Thanks, I can reproduce with your custom settings. Will look into it.

from filtersregistry.

I customized them a long time ago, is that the cause ?

from filtersregistry.