Heap Buffer overflow about admesh HOT 3 OPEN

Thanks for reporting. Can you plese test with some older versions to see if this is a regression?

from admesh.

Also, it's generally a good idea to look at https://github.com/alexrj/Slic3r if this was not fixed there.

from admesh.

thanks for the quick answer;
I've tried with 0.98.0 and 0.97.0 with same buffer overflow.
I searched like suggested in slic3r issues and found slic3r/Slic3r#3317 that seems to be exactly the same.
according to what's written, it's fixed in 1.3.0 version of slicer, so I've downloaded source code of slicer, replaced admesh source code by the one found in slicer (xs/src/admesh), compiled it and it worked.

In order to be sure, I ran address sanitizer on it too, no more buffer overflow detected. but instead, there is some leaks only at the end of the program, if interested, following is asan report.

==22319==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 651176 byte(s) in 1 object(s) allocated from:
#0 0x4aad74 in calloc /tmp/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:56
#1 0x7f9cd82f9d73 in stl_initialize_facet_check_nearby(stl_file*) /home/xxx/Téléchargements/admesh/admesh-0.98.2/src/connect.c:394:33

Indirect leak of 177280 byte(s) in 4432 object(s) allocated from:
#0 0x4aabeb in malloc /tmp/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:40
#1 0x7f9cd82f82f3 in insert_hash_edge(stl_file*, stl_hash_edge, void ()(stl_file, stl_hash_edge*, stl_hash_edge*)) /home/xxx/Téléchargements/admesh/admesh-0.98.2/src/connect.c:208:32

Indirect leak of 28120 byte(s) in 703 object(s) allocated from:
#0 0x4aabeb in malloc /tmp/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:40
#1 0x7f9cd82f83bb in insert_hash_edge(stl_file*, stl_hash_edge, void ()(stl_file, stl_hash_edge*, stl_hash_edge*)) /home/xxx/Téléchargements/admesh/admesh-0.98.2/src/connect.c:228:36

Indirect leak of 40 byte(s) in 1 object(s) allocated from:
#0 0x4aabeb in malloc /tmp/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:40
#1 0x7f9cd82f9da3 in stl_initialize_facet_check_nearby(stl_file*) /home/xxx/Téléchargements/admesh/admesh-0.98.2/src/connect.c:397:31

from admesh.