Binary search should return closest value larger than search value about leonardo HOT 10 CLOSED

@NateBaldwinDesign I have fixed it and raised a PR #104 for the same. Please review it.

from leonardo.

Hi @NateBaldwinDesign I would like to work on this. Please can you assign it to me.

from leonardo.

Hi @NateBaldwinDesign, Can you please assign this issue to me? I would like to work on it

from leonardo.

If I am not wrong this has already been fixed.

from leonardo.

Oops! thank you for the confirmation, @fedeci

from leonardo.

@fedeci It does not work for all the scenarios. Please find below the test cases for which it fails

1. Should return closest match (ascending)
   list = [2, 2.9, 3.01, 3.03];
   value = 3

2. Should return closest match (descending)
   list = [12, 5, 3.3, 3.14, 3.13, 3.12, 3.1, 3.07, 3, 2, 1]
   value = 3.09

from leonardo.

@bhavika24 You are right, I run tests a couple months ago only evaluating ascending order. My fault.

from leonardo.

@FazeelUsmani if you are still interested I can assign this to you. See @bhavika24 's example above. This still needs fixed

from leonardo.

@FazeelUsmani if you are still interested I can assign this to you. See @bhavika24 's example above. This still needs fixed

Yeah, I'm interested, @NateBaldwinDesign

from leonardo.

I see @bhavika24 has already fixed the issue. Do check and let me know if the issue still persists, @NateBaldwinDesign

from leonardo.