Giter VIP home page Giter VIP logo

Comments (5)

LFDanLu avatar LFDanLu commented on June 11, 2024 1

This is a known issue, typically we've had to add the following to whichever drop handler is being used to properly parse the dropped data for Android. We debated about adding this to the docs examples but felt it would just make them more complex/longer. We can definitely consider adding it to the examples or at least a call out somewhere in the docs.

from react-spectrum.

LFDanLu avatar LFDanLu commented on June 11, 2024 1

Yeah, we have been trying to find a good balance between making the docs informative yet not too dense/unapproachable. At the time we debated whether or not to include this snippet of code since it was quite specific but would need to be included in some fashion in every drop handler, but perhaps we could just have a FAQ section somewhere and link to it at the start of every DnD example section.

from react-spectrum.

staticshock avatar staticshock commented on June 11, 2024 1

In their current state, the docs are obviously very useful as a way to learn about the capabilities of the framework. It makes sense for each example to showcase a specific feature with the highest possible signal-to-noise ratio.

Deceptively, they also appear to be good reference implementations, even though it sounds like they aren't, and in retrospect I understand why they shouldn't strive to be. In my ideal world, whenever an example elides something that would have to be included in a real world implementation, it would be awesome to see a link to a reference implementation. "Warning: this example simplifies some things for the sake of illustration. For support across a wide range of devices, see this reference implementation."

(I'm not asking, by the way, just thinking out loud. In the grand scheme of things, I'd put much higher value on fixes to logic issues I've run into, such as the inconsistent handling of trackpads with tap-to-click enabled.)

from react-spectrum.

BenjaminLucier avatar BenjaminLucier commented on June 11, 2024

Same issue for me.

from react-spectrum.

staticshock avatar staticshock commented on June 11, 2024

I've been working through a few issues in my own use of React Aria's DnD recently, especially on mobile, and I thought it was logical to check if the React Aria docs exhibit the same issues. If they do, I reasoned, then there's a bug in the framework, and if they don't, then the bug is probably on my end. It never even occurred to me that bugs in the React Aria docs would be deliberately there to make the code look simpler than it would be in reality, which is what I think you're suggesting.

from react-spectrum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.