Giter VIP home page Giter VIP logo

Comments (3)

sossost avatar sossost commented on May 29, 2024 2

Hello, @snowystinger! I am sossost, a new contributor. Can I resolve this issue??

from react-spectrum.

snowystinger avatar snowystinger commented on May 29, 2024 1

Go for it

from react-spectrum.

snowystinger avatar snowystinger commented on May 29, 2024

This is classified by Deque as a best practice rule: https://dequeuniversity.com/rules/axe/4.8#best-practices-rules.
It should be noted that our Digital Accessibility Guide - Comprehensive Testing guidance recommends running aXe with best practices ‘OFF’: https://accessibility.corp.adobe.com/testing/web/manual_checklist/#running-axe-devtools.

This is not a false positive, because article does not technically accept the widget role of gridcell, per the Document conformance requirements for use of ARIA attributes in HTML. The use of article for a Card would make more sense when if we were implementing the WAI-ARIA feed design pattern, which behaves similarly to a grid, but expects children of the role="feed" to have role="article". Making the change to use feed rather than grid might affect behaviors like item selection and how a Windows screen reader shifts into and out of forms mode.

While the impact on accessibility caused by using the gridcell role on an article within a grid is low, it might be better to use a generic div instead of article . That way we could use either role="gridcell" or role=article depending on the context.

from react-spectrum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.