Giter VIP home page Giter VIP logo

Comments (3)

yihuiliao avatar yihuiliao commented on July 24, 2024

I think you'll need to placeisDismissable on the ModalOverlay component instead of the Modal component. Someone else reported that this wasn't clear in our docs (#6277). Let us know if that solves your issue.

from react-spectrum.

daninus14 avatar daninus14 commented on July 24, 2024

Thank you!

It appears nowhere in the page (i found out a seemingly hidden link here https://react-spectrum.adobe.com/react-aria/Modal.html#advanced-customization which pops up props for modal overlay now that you mentioned it). It should be either in advanced customization, or really ModalOverlay should have a page for itself.

How many other components don't have their own page? As a user I think the documentation would be much better if each component has a page for itself. This is an open source project and I am tremendously grateful for the contribution.

Thanks so much, at least now hopefully people will find this by googling this issue :D

from react-spectrum.

daninus14 avatar daninus14 commented on July 24, 2024

Oh by the way, I think adding that to the tailwind example may also be very helpful. I was using a workaround by using plain css and not using the modal overlay at all

from react-spectrum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.