Giter VIP home page Giter VIP logo

Comments (3)

snowystinger avatar snowystinger commented on July 24, 2024

I corrected your sandbox so it didn't have duplicate keys and I'm unable to reproduce. Please check if you have duplicate keys

from react-spectrum.

RajaTheKing826 avatar RajaTheKing826 commented on July 24, 2024

I've forgotten to update the keys, yes the keys are the reason for getting those white, but if I increase my option height still im getting the white spaces even though i have given the unique keys.

And i found the reason too.

In our listbox base we are fixing the estimated row height as some px.

let layout = useMemo(
    () =>
      new ListLayout<T>({
        estimatedRowHeight: scale === "large" ? 48 : 44,
        estimatedHeadingHeight: scale === "large" ? 33 : 32,
        padding: scale === "large" ? 5 : 4, // TODO: get from DNA
        loaderHeight: 44,
        placeholderHeight: scale === "large" ? 48 : 44,
        collator,
      }),
    [collator, scale]
  );

When i try to give more height to option manually then i'm getting this blank space. So if i want to increase the height of the option outise, then i need to increase the estimated height in layout too.

I got this, but I don't know how this is causing the white spaces can you give me any brief what is this layout and how it effecting the blankspace.

from react-spectrum.

snowystinger avatar snowystinger commented on July 24, 2024

I can't reproduce. Can you update the reproduction instructions or update the sandbox if it isn't reproducing for you there either?

from react-spectrum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.