Comments (22)
We got an internal discussion today, here is the latest feedback and final structure we will use.
- We are going to merge
AdonisJS Concepts
andArchitecture Concepts
- Rename
Request Lifecycle
toHttp Overview
- We keep the
Bodyparser
section outside ofRequests
- We don't merge
Assets Bundling
andStatic File Server
- We rename
Assets Bundling
toVite
- We move the
Internals
section toConcepts
- We move
Extending the framework
toConcepts
- We move
Repl
toDigging Deeper
Final structure:
Preface
βββ Introduction
βββ FAQ
βββ Governance
βββ Release Notes
βββ Contribution Guide
Getting Started
βββ Installation
βββ Configuration
βββ Environment Variables
βββ Folder Structure
βββ Deployment
Concepts
βββ Async Local Storage
βββ Application
βββ Application Lifecycle
βββ Config Providers
βββ Container Services
βββ Dependency Injection
βββ Extending the framework
βββ HMR
βββ Http Overview
βββ Http Context
βββ RC Files
βββ Service Providers
βββ Scaffolding
βββ Tooling Config
βββ TypeScript Build
Basics
βββ Routing
βββ Controllers
βββ Middleware
βββ Bodyparser
βββ Requests
βββ Response
βββ Validation
βββ File Upload
βββ Session
βββ Cookies
βββ Exception Handling
βββ Vite
βββ Static Assets
Database
βββ Introduction
βββ Lucid ORM
βββ Redis
Authentication
βββ Introduction
βββ User Credentials
βββ Session Guard
βββ Access Token Guard
βββ Basic Auth Guard
βββ Custom Auth Guard
βββ Social Authentication
Security
βββ Introduction
βββ Authorization
βββ Encryption
βββ Hashing
βββ Signed URLs
βββ Web Security
βββ Rate Limiting
Views & Templates
βββ Introduction
βββ EdgeJS
βββ InertiaJS
Testing
βββ Introduction
βββ Http Tests
βββ Browser Tests
βββ Console Tests
βββ Database
βββ Mocks & Fakes
Digging Deeper
βββ Ace Commands
βββ Caching
βββ Emitter
βββ I18n
βββ Locks
βββ Logger
βββ Mail
βββ Transmit
βββ Repl
Ace Commands
βββ NO CHANGE
API References
βββ NO CHANGE
Experimentals
βββ NO CHANGE
from v6-docs.
Extending the framework could be a separate section since this could cover extentions for a module like the HTTP request, Vine, a new social auth AND having a page dedicated to how dev can create externals and sharables modules.
Customization is one of the strength of the framework and it should really be highlighted in the nav!
from v6-docs.
+1 for me, I think is a great change! I think one thing we are missing as a community is more example projects.
This is planned as part of our "Bootcamp" project.
from v6-docs.
SGTM,
I suggest to separate Auth Guards in to sub-pages
Authentication
βββ Auth Guards # generic information about auth guards, how to apply, and name them.
βββ Session Guard
βββ Access Token Guard
βββ Basic Auth Guard
βββ Custom Auth Guard
from v6-docs.
+1 for me, I think is a great change! I think one thing we are missing as a community is more example projects.
from v6-docs.
Yup, looks good.
A few things to note.
User Credentials
should beVerifying user credentials
because the term "User Credentials" does not convey anything.Release Notes
should beReleases
because we list the releases only here, and the notes are on Github.TypeScript Build
should beTypeScript build process
to complete the sentence.- In security, we are missing CORS.
- Again, I prefer "Securing SSR apps" over "Web security". Aligns more with the intent of the doc.
- There won't be
Ace Commands
in digging deeper for now. Until we move Ace docs to its own website.
Also, I noticed that you went with "Title case" in all the topic names. However, currently, the documentation follows the "Sentence case". There is nothing wrong with either of those. Even from the English point of view, both are technically correct. But for consistency, we should stick with "Sentence case."
Finally, once we move content around. We should double-check:
- If any URLs are changing and must define redirects for them.
- Also, update internal links if the content files are moved to different folders. Right now, the links are resolved from the location of the file.
from v6-docs.
What a great improvement! I'm pleased to see this proposal!
For the HMR page, I'd rather see it in the internal tooling section more than in the architecture concept since it's just a flag with the serve command and this does not impact how the dev will use Adonis.
from v6-docs.
For the HMR page, I'd rather see it in the internal tooling section more than in the architecture concept since it's just a flag with the serve command and this does not impact how the dev will use Adonis.
I place it here because it is a concept linked to Node.js (not AdonisJS). However, it could also go inside the Internal
section since it is not something someone has to know.
from v6-docs.
Nice one! The only thing I would change: Preface -> General. Feels like the word βGeneralβ gives a little bit more freedom to put inside it something more general about the framework. And I would not shy off from adding βDonationsβ section into it.
from v6-docs.
nit:
in
Preface
βββ Introduction (From: Getting Started - Introduction)
βββ FAQ
βββ Governance
βββ Release Notes
βββ Contribution Guide
I would put FAQ
and Release Notes
closer (imho something not in the release note should be in the FAQ and vice versa)
while Contribution Guide
should follow the Governance
(gouvernance could impact the contrib policy imho)
Proposal
Preface
βββ Introduction (From: Getting Started - Introduction)
βββ FAQ
βββ Release Notes
βββ Contribution Guide
βββ Governance
from v6-docs.
This is really cool π 1+ for me
from v6-docs.
Do you mean the second proposal or to have a third level in the sidebar?
Because you mixed the two in your message.I mean have a third level in the sidebar
In my opinion, that will clutter the sidebar too much and it is not currently doable in our documentation software.
from v6-docs.
If we do that, we are splitting the content again, which I want to avoid. What are your goals with this change?
from v6-docs.
better readability and discoverability, avoiding put too much content in a single page.
Then you want the second solution. Otherwise, we are cluttering the sidebar too much, and people will be lost with too much section.
Also, having more content on the same page has never been an issue. It allows you to easily search and avoid switching back and forth on multiple pages. You want to learn about "Auth Guard"? Go to the "Auth Guard" section and start to read from here.
For example, this is done in AdonisJS 5 or Laravel for the Mail
section, and it was fine.
I think a section like tutorial or recipes will be great for newcomers. The current docs is more of an API reference, and if you want to implement something in your app, you have to watch videos (which are great, but doesn't cover cases where you need a quick look or prefer text content) or dig the docs and connect the puzzle pieces by yourself.
This is not the goal of the documentation and is already planned in the Bootcamp project.
The documentation will not teach you how to build an app from scratch. For that, we plan to write step-by-step tutorials that teach you how to build a specific app using the framework.
from v6-docs.
SGTM, I suggest to separate Auth Guards in to sub-pages
Authentication βββ Auth Guards # generic information about auth guards, how to apply, and name them. βββ Session Guard βββ Access Token Guard βββ Basic Auth Guard βββ Custom Auth Guard
Do you mean the second proposal or to have a third level in the sidebar?
Because you mixed the two in your message.
First Proposal: merge all guard documentation under the same page Auth Guards
Authentication
βββ Introduction
βββ User Providers
βββ Auth Guards
βββ Social Authentication
Second Proposal: keep the guard documentation separated on their own page
Authentication
βββ Introduction
βββ User Providers
βββ Session Guard
βββ Access Token Guard
βββ Basic Auth Guard
βββ Custom Auth Guard
βββ Social Authentication
The goal was to replicate a schema I showed during meetup/talk.
from v6-docs.
Do you mean the second proposal or to have a third level in the sidebar?
Because you mixed the two in your message.
I mean have a third level in the sidebar
from v6-docs.
What do you think about make an "Auth Guards" or "Authentication Guards" section ?
Authentication
βββ Introduction
βββ User Providers
βββ Social Authentication
Auth Guards
βββ Introduction
βββ Session Guard
βββ Access Token Guard
βββ Basic Auth Guard
βββ Custom Auth Guard
from v6-docs.
better readability and discoverability, avoiding put too much content in a single page.
from v6-docs.
I think a section like tutorial or recipes will be great for newcomers. The current docs is more of an API reference, and if you want to implement something in your app, you have to watch videos (which are great, but doesn't cover cases where you need a quick look or prefer text content) or dig the docs and connect the puzzle pieces by yourself.
from v6-docs.
Something like:
https://docs.strapi.io/dev-docs/quick-start
https://nextjs.org/learn/dashboard-app
from v6-docs.
This is amazing work! Well done, much respect π
I believe the final version is much clearer than the previous docs.
from v6-docs.
ππ»
You are invited to give your feedback on the PR: #86
You can see the changes there: https://feat-new-structure.v6-docs.pages.dev/guides/preface/introduction
from v6-docs.
Related Issues (20)
- response.accessDenied() does not exist but is recommended in the documentation HOT 1
- Lucid documentation bad link from search engine HOT 1
- Reference to Packages
- Health Check HOT 2
- How to save auth tokens with redis driver ? HOT 1
- Create a dedicated template to report issue HOT 1
- New docs is hard to read and understand HOT 3
- Weird phrasing in `Views and Templates` HOT 2
- `Passing metadata to validator` examples do not work HOT 1
- Possible typo in documentation - `ref` instead of `rel` HOT 2
- Feature request - Prev/Next page links HOT 1
- i18n Not working AdonisJS 6 HOT 2
- Full file examples HOT 3
- Creating a custom auth guard guide doesn't work
- Auth custom guard HOT 1
- extend DatabaseQueryBuilder
- Installation error with yarn HOT 8
- Ally setup command with multiple `--providers` is not working
- guardFactory is not a function HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from v6-docs.