Giter VIP home page Giter VIP logo

Comments (22)

RomainLanz avatar RomainLanz commented on May 20, 2024 8

We got an internal discussion today, here is the latest feedback and final structure we will use.

  • We are going to merge AdonisJS Concepts and Architecture Concepts
  • Rename Request Lifecycle to Http Overview
  • We keep the Bodyparser section outside of Requests
  • We don't merge Assets Bundling and Static File Server
  • We renameAssets Bundling to Vite
  • We move the Internals section to Concepts
  • We move Extending the framework to Concepts
  • We move Repl to Digging Deeper

Final structure:

Preface
β”œβ”€β”€ Introduction
β”œβ”€β”€ FAQ
β”œβ”€β”€ Governance
β”œβ”€β”€ Release Notes
└── Contribution Guide

Getting Started
β”œβ”€β”€ Installation
β”œβ”€β”€ Configuration
β”œβ”€β”€ Environment Variables
β”œβ”€β”€ Folder Structure
└── Deployment

Concepts
β”œβ”€β”€ Async Local Storage
β”œβ”€β”€ Application
β”œβ”€β”€ Application Lifecycle
β”œβ”€β”€ Config Providers
β”œβ”€β”€ Container Services
β”œβ”€β”€ Dependency Injection
β”œβ”€β”€ Extending the framework
β”œβ”€β”€ HMR
β”œβ”€β”€ Http Overview
β”œβ”€β”€ Http Context
β”œβ”€β”€ RC Files
β”œβ”€β”€ Service Providers
β”œβ”€β”€ Scaffolding
β”œβ”€β”€ Tooling Config
└── TypeScript Build

Basics
β”œβ”€β”€ Routing
β”œβ”€β”€ Controllers
β”œβ”€β”€ Middleware
β”œβ”€β”€ Bodyparser
β”œβ”€β”€ Requests
β”œβ”€β”€ Response
β”œβ”€β”€ Validation
β”œβ”€β”€ File Upload
β”œβ”€β”€ Session
β”œβ”€β”€ Cookies
β”œβ”€β”€ Exception Handling
β”œβ”€β”€ Vite
└── Static Assets

Database
β”œβ”€β”€ Introduction
β”œβ”€β”€ Lucid ORM
└── Redis

Authentication
β”œβ”€β”€ Introduction
β”œβ”€β”€ User Credentials
β”œβ”€β”€ Session Guard
β”œβ”€β”€ Access Token Guard
β”œβ”€β”€ Basic Auth Guard
β”œβ”€β”€ Custom Auth Guard
└── Social Authentication

Security
β”œβ”€β”€ Introduction
β”œβ”€β”€ Authorization
β”œβ”€β”€ Encryption
β”œβ”€β”€ Hashing
β”œβ”€β”€ Signed URLs
β”œβ”€β”€ Web Security
└── Rate Limiting

Views & Templates
β”œβ”€β”€ Introduction
β”œβ”€β”€ EdgeJS
└── InertiaJS

Testing
β”œβ”€β”€ Introduction
β”œβ”€β”€ Http Tests
β”œβ”€β”€ Browser Tests
β”œβ”€β”€ Console Tests
β”œβ”€β”€ Database
└── Mocks & Fakes

Digging Deeper
β”œβ”€β”€ Ace Commands
β”œβ”€β”€ Caching
β”œβ”€β”€ Emitter
β”œβ”€β”€ I18n
β”œβ”€β”€ Locks
β”œβ”€β”€ Logger
β”œβ”€β”€ Mail
β”œβ”€β”€ Transmit
└── Repl

Ace Commands
└── NO CHANGE

API References
└── NO CHANGE

Experimentals
└── NO CHANGE

from v6-docs.

Barbapapazes avatar Barbapapazes commented on May 20, 2024 5

Extending the framework could be a separate section since this could cover extentions for a module like the HTTP request, Vine, a new social auth AND having a page dedicated to how dev can create externals and sharables modules.

Customization is one of the strength of the framework and it should really be highlighted in the nav!

from v6-docs.

RomainLanz avatar RomainLanz commented on May 20, 2024 5

+1 for me, I think is a great change! I think one thing we are missing as a community is more example projects.

This is planned as part of our "Bootcamp" project.

from v6-docs.

tpoisseau avatar tpoisseau commented on May 20, 2024 3

SGTM,
I suggest to separate Auth Guards in to sub-pages

Authentication
β”œβ”€β”€ Auth Guards # generic information about auth guards, how to apply, and name them.
    β”œβ”€β”€ Session Guard
    β”œβ”€β”€ Access Token Guard
    β”œβ”€β”€ Basic Auth Guard
    β”œβ”€β”€ Custom Auth Guard

from v6-docs.

britzdylan avatar britzdylan commented on May 20, 2024 3

+1 for me, I think is a great change! I think one thing we are missing as a community is more example projects.

from v6-docs.

thetutlage avatar thetutlage commented on May 20, 2024 3

Yup, looks good.

A few things to note.

  • User Credentials should be Verifying user credentials because the term "User Credentials" does not convey anything.
  • Release Notes should be Releases because we list the releases only here, and the notes are on Github.
  • TypeScript Build should be TypeScript build process to complete the sentence.
  • In security, we are missing CORS.
  • Again, I prefer "Securing SSR apps" over "Web security". Aligns more with the intent of the doc.
  • There won't be Ace Commands in digging deeper for now. Until we move Ace docs to its own website.

Also, I noticed that you went with "Title case" in all the topic names. However, currently, the documentation follows the "Sentence case". There is nothing wrong with either of those. Even from the English point of view, both are technically correct. But for consistency, we should stick with "Sentence case."

Finally, once we move content around. We should double-check:

  • If any URLs are changing and must define redirects for them.
  • Also, update internal links if the content files are moved to different folders. Right now, the links are resolved from the location of the file.

from v6-docs.

Barbapapazes avatar Barbapapazes commented on May 20, 2024 2

What a great improvement! I'm pleased to see this proposal!

For the HMR page, I'd rather see it in the internal tooling section more than in the architecture concept since it's just a flag with the serve command and this does not impact how the dev will use Adonis.

from v6-docs.

RomainLanz avatar RomainLanz commented on May 20, 2024 1

For the HMR page, I'd rather see it in the internal tooling section more than in the architecture concept since it's just a flag with the serve command and this does not impact how the dev will use Adonis.

I place it here because it is a concept linked to Node.js (not AdonisJS). However, it could also go inside the Internal section since it is not something someone has to know.

from v6-docs.

bitkidd avatar bitkidd commented on May 20, 2024 1

Nice one! The only thing I would change: Preface -> General. Feels like the word β€œGeneral” gives a little bit more freedom to put inside it something more general about the framework. And I would not shy off from adding β€œDonations” section into it.

from v6-docs.

Mizux avatar Mizux commented on May 20, 2024 1

nit:
in

Preface
β”œβ”€β”€ Introduction (From: Getting Started - Introduction)
β”œβ”€β”€ FAQ
β”œβ”€β”€ Governance
β”œβ”€β”€ Release Notes
└── Contribution Guide

I would put FAQ and Release Notes closer (imho something not in the release note should be in the FAQ and vice versa)
while Contribution Guide should follow the Governance (gouvernance could impact the contrib policy imho)

Proposal

Preface
β”œβ”€β”€ Introduction (From: Getting Started - Introduction)
β”œβ”€β”€ FAQ
β”œβ”€β”€ Release Notes
β”œβ”€β”€ Contribution Guide
└── Governance

from v6-docs.

Foysal50x avatar Foysal50x commented on May 20, 2024 1

This is really cool πŸ‘ 1+ for me

from v6-docs.

RomainLanz avatar RomainLanz commented on May 20, 2024 1

@RomainLanz

Do you mean the second proposal or to have a third level in the sidebar?
Because you mixed the two in your message.

I mean have a third level in the sidebar

In my opinion, that will clutter the sidebar too much and it is not currently doable in our documentation software.

from v6-docs.

RomainLanz avatar RomainLanz commented on May 20, 2024 1

If we do that, we are splitting the content again, which I want to avoid. What are your goals with this change?

from v6-docs.

RomainLanz avatar RomainLanz commented on May 20, 2024 1

better readability and discoverability, avoiding put too much content in a single page.

Then you want the second solution. Otherwise, we are cluttering the sidebar too much, and people will be lost with too much section.

Also, having more content on the same page has never been an issue. It allows you to easily search and avoid switching back and forth on multiple pages. You want to learn about "Auth Guard"? Go to the "Auth Guard" section and start to read from here.

For example, this is done in AdonisJS 5 or Laravel for the Mail section, and it was fine.

I think a section like tutorial or recipes will be great for newcomers. The current docs is more of an API reference, and if you want to implement something in your app, you have to watch videos (which are great, but doesn't cover cases where you need a quick look or prefer text content) or dig the docs and connect the puzzle pieces by yourself.

This is not the goal of the documentation and is already planned in the Bootcamp project.

The documentation will not teach you how to build an app from scratch. For that, we plan to write step-by-step tutorials that teach you how to build a specific app using the framework.

from v6-docs.

RomainLanz avatar RomainLanz commented on May 20, 2024

SGTM, I suggest to separate Auth Guards in to sub-pages

Authentication
β”œβ”€β”€ Auth Guards # generic information about auth guards, how to apply, and name them.
    β”œβ”€β”€ Session Guard
    β”œβ”€β”€ Access Token Guard
    β”œβ”€β”€ Basic Auth Guard
    β”œβ”€β”€ Custom Auth Guard

Do you mean the second proposal or to have a third level in the sidebar?
Because you mixed the two in your message.

First Proposal: merge all guard documentation under the same page Auth Guards

Authentication
β”œβ”€β”€ Introduction
β”œβ”€β”€ User Providers
β”œβ”€β”€ Auth Guards
└── Social Authentication

Second Proposal: keep the guard documentation separated on their own page

Authentication
β”œβ”€β”€ Introduction
β”œβ”€β”€ User Providers
β”œβ”€β”€ Session Guard
β”œβ”€β”€ Access Token Guard
β”œβ”€β”€ Basic Auth Guard
β”œβ”€β”€ Custom Auth Guard
└── Social Authentication

The goal was to replicate a schema I showed during meetup/talk.

StrasbourgJS Adonis 6

from v6-docs.

tpoisseau avatar tpoisseau commented on May 20, 2024

@RomainLanz

Do you mean the second proposal or to have a third level in the sidebar?
Because you mixed the two in your message.

I mean have a third level in the sidebar

from v6-docs.

tpoisseau avatar tpoisseau commented on May 20, 2024

What do you think about make an "Auth Guards" or "Authentication Guards" section ?

Authentication
β”œβ”€β”€ Introduction
β”œβ”€β”€ User Providers
└── Social Authentication

Auth Guards
β”œβ”€β”€ Introduction
β”œβ”€β”€ Session Guard
β”œβ”€β”€ Access Token Guard
β”œβ”€β”€ Basic Auth Guard
└── Custom Auth Guard

from v6-docs.

tpoisseau avatar tpoisseau commented on May 20, 2024

better readability and discoverability, avoiding put too much content in a single page.

from v6-docs.

ShahriarKh avatar ShahriarKh commented on May 20, 2024

I think a section like tutorial or recipes will be great for newcomers. The current docs is more of an API reference, and if you want to implement something in your app, you have to watch videos (which are great, but doesn't cover cases where you need a quick look or prefer text content) or dig the docs and connect the puzzle pieces by yourself.

from v6-docs.

ShahriarKh avatar ShahriarKh commented on May 20, 2024

Something like:
https://docs.strapi.io/dev-docs/quick-start
https://nextjs.org/learn/dashboard-app

from v6-docs.

aarhusgregersen avatar aarhusgregersen commented on May 20, 2024

This is amazing work! Well done, much respect πŸ™
I believe the final version is much clearer than the previous docs.

from v6-docs.

RomainLanz avatar RomainLanz commented on May 20, 2024

πŸ‘‹πŸ»

You are invited to give your feedback on the PR: #86

You can see the changes there: https://feat-new-structure.v6-docs.pages.dev/guides/preface/introduction

from v6-docs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.