Comments (1)
👀 If I change ember-cp-validations/addon/-private/options.js
from:
export default class Options {
constructor({ model, attribute, options = {} }) {
const optionKeys = keys(options);
const createParams = { [OPTION_KEYS]: optionKeys, model, attribute };
// If any of the options is a CP, we need to create a custom class for it
if (optionKeys.some((key) => isDescriptor(options[key]))) {
return OptionsObject.extend(options).create(createParams);
}
return OptionsObject.create(createParams, options);
}
}
to:
export default class Options {
constructor({ model, attribute, options = {} }) {
const optionKeys = keys(options);
const createParams = { [OPTION_KEYS]: optionKeys, model, attribute };
const someOptionsAreCPs = optionKeys.some((key) => {
return isDescriptor(options[key]) || options[key]?.constructor?.name === 'AliasDecoratorImpl'
});
// If any of the options is a CP, we need to create a custom class for it
if (someOptionsAreCPs) {
return OptionsObject.extend(options).create(createParams);
}
return OptionsObject.create(createParams, options);
}
}
the error is gone and everything works.
Is this a valid fix ? Should I open a PR ?
Bear in mind that I'm only having the Error when running the embroider-safe scenario and not the default scenario on Ember 4.12.
🤔
from ember-cp-validations.
Related Issues (20)
- Has-many relationship propagates 'messages' property but not 'errors' property
- Validations including a has-many relationship broken when lazily evaluated
- Getting Unit Tests to Work HOT 3
- Assertion Failed with Embroider HOT 3
- Ember CP validation does not support ember octane with glimmer component HOT 4
- After update to ember 3.27.5 there is an error: Uncaught TypeError: (0 , _string.isHTMLSafe) is not a function HOT 8
- Ember Global deprecation warning due to old version of ember-cli-babel HOT 4
- Installing this addon breaks build on Ember 4 HOT 1
- Running ember-cp-validations using typescript
- Documentation site no longer exists HOT 1
- Release strategy HOT 27
- Setup release, changelog, etc according to the guidelines HOT 3
- Setup Docs HOT 1
- [Feature Request] Restore date validator capabilities re: 'format' and 'precision,' and allow use of 'now' as a reference time HOT 8
- Multiple conditionally required fields validation
- Validations with EmberObject does not work? HOT 3
- 3.x Documentation link is down
- Embroider: Use of ember internals
- Embroider: Use of ember-data internals HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-cp-validations.