Comments (2)
I feel this is not only a specific function is used or not. There are lots of problems. Below are some examples:
-
Instead of writing code to filter and find the latest run, can we query on date?
https://github.com/AdoptOpenJDK/openjdk-test-tools/blob/69e586c031d71e49d694edd944af9e591cd10ba2/TestResultSummaryService/routes/getTabularData.js#L47-L67 -
why loop through all info and string concat into
benchmarkNVM
, then splitbenchmarkNVM
get the values back?
benchmarkNVM = testResultsObject.aggregateInfo[aggregateIndex].benchmarkName + ',' + testResultsObject.aggregateInfo[aggregateIndex].benchmarkVariant + "," + testResultsObject.aggregateInfo[aggregateIndex].metrics[metric].name;
- lots of unused variables: https://github.com/AdoptOpenJDK/openjdk-test-tools/blob/69e586c031d71e49d694edd944af9e591cd10ba2/TestResultSummaryService/routes/getTabularDropdown.js#L8
...
Before we dive into fixing the code, I would like to take a step back and go over the design of the Tabular View and understand the use cases. To me, both client TabularView.jsx and server logic for Tabular View seem convoluted.
from aqa-test-tools.
@llxia After some initial review for Tabular View, we didn't end up using the snippet with distinct
mentioned above. This issue was created a few days before the final changes were merged, so we have cleaned up and optimized most things already.
Mentioning some relevant snippets below. If you have any specific suggestions on how to optimize the queries further, please mention it. Thanks!
from aqa-test-tools.
Related Issues (20)
- Add queue time information HOT 4
- Added pipelines for monitoring seems to duplicate themselves HOT 1
- [Enhancement] Collapse All button for TRSS buildTreeView HOT 1
- Release Summary report Rerun link causing a 'comment is too long' issue HOT 1
- Add Netlify attribution to TRSS client page
- Since we upgrade the node, we should upgrade to 18. 16 is out of active support and security support for 16 will end in Sep 2023. HOT 2
- Enhance docker compose in TRSS HOT 1
- Set TRSS link in the Jenkins job HOT 2
- Uncontrolled data used in path expression
- Store and display ML user feedback counts HOT 1
- Bug: JDK21 Build links missing from TRSS pipeline grid view HOT 2
- TRSS server container OOM
- Chatbot for Efficient Issue Triage and Resolution
- Mac test results are not showing up in Grid or Tree views HOT 1
- Release Summary Report should display the Rerun build result
- Not all child jobs showing in Tree and Grid view for release builds HOT 3
- JDK23 builds not showing in Grid view
- Uncaught Error when adding new build via TRSS admin page
- Add support for fips140_2 and fips_3_YYYYMMDD HOT 1
- test targets under different variant are categorized incorrectly HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aqa-test-tools.