Smoke tests for MSI installer generation failed about installer HOT 9 CLOSED

So I propose to add smoke code again and an option to disable it if needed

from installer.

this was caused by wixtoolset/issues#4922. We don't build with an admin user so they were unable to install

from installer.

This PR re-enables smoke testing like we did before #67

from installer.

This PR re-enables smoke testing like we did before

We having random failure with test enable like before (without option -sval for light.exe)
So smoke is not the problem as light get random error too

Actually there is not any validation done.
Not by light ( because of usage of -sval ) and not with smoke.exe a then end.
It is not a best practice to skip all msi validation.

We must find .. why the failure is random and enable test again within light or smoke(at then end)

First to try on another host to see if smoke work without admin user.
If YES then

Some hint to validate here :
https://stackoverflow.com/questions/1064580/wix-3-0-throws-error-217-while-being-executed-by-continuous-integration

• PATH too long
• corrupted Windows Installer Service
• restart the Windows Installer service
• mcafee has replaced path to dll: updated the path back to c:\windows\system32\vbscript.dll

workaround to try maybe :

• change the account used to run the service on my machine. Instead of using Network Service or Local Service I simply made the service log on with my own account which had all the necessary rights.

from installer.

I just tested on my Windows 10 machine:
Service "Windows Installer" (msiexec 5.0.17134.228) is stopped and configured by default with "Manual starting" and "Local system" account

With user without any group provilège it works without erreur :
light without -sval works without error
smoke works without error

from installer.

smoke (msi validation) can be disabled/enabled by PR #71

Maybe interactif user (non admin) can access windows installer
https://sourceforge.net/p/wix/mailman/message/24361610/

If jenkins slave is executed as a service we can try do enable "interactive" on that service
or start slave agent outside of a service
https://groups.google.com/forum/#!topic/jenkinsci-users/Z7-VY1l-7hE

https://community.smartbear.com/t5/TestComplete-Desktop-Testing/quot-Interactive-user-session-quot-issue-with-TestComplete-and/td-p/105595

and as Jenkins stated:
https://wiki.jenkins.io/display/JENKINS/Distributed+builds#Distributedbuilds-HavemasterlaunchagentonWindows

This is the most convenient set up on Windows, but does not allow you to run programs that require display interaction (such as GUI tests).

If you need display interaction (e.g. for GUI tests) on Windows and you have a dedicated (virtual) test machine, this is a suitable option. Create a jenkins user account, enable auto-login, and put a shortcut to the JNLP file in the Startup items (after having trusted the agent's certificate). This allows one to run tests as a restricted user as well.

from installer.

#71 was merged, smoke testing is enabled. Therefore, I'm closing.

from installer.

This issue was actually about not being able to run the smoke tests on the current build agents because they are running as a non admin user.

from installer.

Wix MSI Smoke test is now used on github actions pipeline (SKIP_MSI_VALIDATION is not set)

from installer.