Giter VIP home page Giter VIP logo

Comments (11)

chriswhocodes avatar chriswhocodes commented on June 2, 2024 1

Thanks for tracking this down. I'll put in a null check so you see an empty call chain instead of it blowing up :)

from jitwatch.

alexei-osipov avatar alexei-osipov commented on June 2, 2024

In class CompileChainStage on line
title += rootMemberName + " " + root.getCompilation().getSignature(); variable root is null.

from jitwatch.

chriswhocodes avatar chriswhocodes commented on June 2, 2024

Hi @alexei-osipov ,
Thanks for reporting. I'll investigate why this is happening and put in a fix.
Kind regards,
Chris

from jitwatch.

alexei-osipov avatar alexei-osipov commented on June 2, 2024

I've noticed that there a lot of errors in the parser log:

Could not parse line 3798 : java.lang.invoke.LambdaForm$MH.0x0000000800060440 invoke (Ljava.lang.Object;)Ljava.lang.Object; : MetaMember not found for java.lang.invoke.LambdaForm$MH.0x0000000800060440 invoke (Ljava.lang.Object;)Ljava.lang.Object;
Could not parse line 3807 : java.lang.invoke.LambdaForm$MH.0x0000000800060440 invoke (Ljava.lang.Object;)Ljava.lang.Object; : MetaMember not found for java.lang.invoke.LambdaForm$MH.0x0000000800060440 invoke (Ljava.lang.Object;)Ljava.lang.Object;
Could not parse line 4661 : java.util.stream.StreamSpliterators$WrappingSpliterator$$Lambda$179.0x000000080023a040 getAsBoolean ()Z : MetaMember not found for java.util.stream.StreamSpliterators$WrappingSpliterator$$Lambda$179.0x000000080023a040 getAsBoolean ()Z

and so on (hundreds of them).

Example log content for lines 3806-3709:

<task_queued compile_id='1363' method='java.lang.Object &lt;init&gt; ()V' bytes='1' count='768' iicount='768' level='1' stamp='1.568' comment='tiered' hot_count='768'/>
<writer thread='33624'/>
<nmethod compile_id='1361' compiler='c1' level='1' entry='0x0000018e449c2540' size='768' address='0x0000018e449c2390' relocation_offset='376' insts_offset='432' stub_offset='592' scopes_data_offset='664' scopes_pcs_offset='680' dependencies_offset='744' nul_chk_table_offset='752' oops_offset='648' metadata_offset='656' method='java.lang.invoke.LambdaForm$MH/0x0000000800060440 invoke (Ljava/lang/Object;)Ljava/lang/Object;' bytes='8' count='381' iicount='381' stamp='1.568'/>
<nmethod compile_id='1363' compiler='c1' level='1' entry='0x0000018e449c28c0' size='696' address='0x0000018e449c2710' relocation_offset='376' insts_offset='432' stub_offset='560' scopes_data_offset='624' scopes_pcs_offset='640' dependencies_offset='688' metadata_offset='616' method='java.lang.Object &lt;init&gt; ()V' bytes='1' count='797' iicount='797' stamp='1.569'/>

Example log content for lines 4660-4663:

<task_queued compile_id='1363' method='java.lang.Object &lt;init&gt; ()V' bytes='1' count='768' iicount='768' level='1' stamp='1.568' comment='tiered' hot_count='768'/>
<writer thread='33624'/>
<nmethod compile_id='1361' compiler='c1' level='1' entry='0x0000018e449c2540' size='768' address='0x0000018e449c2390' relocation_offset='376' insts_offset='432' stub_offset='592' scopes_data_offset='664' scopes_pcs_offset='680' dependencies_offset='744' nul_chk_table_offset='752' oops_offset='648' metadata_offset='656' method='java.lang.invoke.LambdaForm$MH/0x0000000800060440 invoke (Ljava/lang/Object;)Ljava/lang/Object;' bytes='8' count='381' iicount='381' stamp='1.568'/>

Example log content for lines 4660-4663:

<task_queued compile_id='1682' method='java.util.Spliterators$ArraySpliterator tryAdvance (Ljava/util/function/Consumer;)Z' bytes='58' count='256' iicount='256' level='1' stamp='1.976' comment='tiered' hot_count='256'/>
<task_queued compile_id='1683' method='java.util.stream.AbstractSpinedBuffer count ()J' bytes='31' count='256' iicount='256' level='1' stamp='1.976' comment='tiered' hot_count='256'/>
<task_queued compile_id='1684' method='java.util.stream.StreamSpliterators$WrappingSpliterator$$Lambda$179/0x000000080023a040 getAsBoolean ()Z' bytes='8' count='256' iicount='256' level='1' stamp='1.976' comment='tiered' hot_count='256'/>
<task_queued compile_id='1685' method='java.util.stream.StreamSpliterators$WrappingSpliterator lambda$initPartialTraversalState$0 ()Z' bytes='14' count='256' iicount='256' level='1' stamp='1.976' comment='tiered' hot_count='256'/>

Note that it seems that error log messages point to a bit wrong line numbers. Error mentions log line 4661 but the relevant content seems to be on line 4662.

from jitwatch.

chriswhocodes avatar chriswhocodes commented on June 2, 2024

"Could not parse" for lambdas is a known problem. The solution requires a bit of a redesign which is currently in (slow) progress.

Looks like there's an off-by-one in reporting the errors lines. Will fix that :)

from jitwatch.

alexei-osipov avatar alexei-osipov commented on June 2, 2024

I guess that parsing issue is not actually related to the NPE problem then.

Is there any information that might be helpful for you?

from jitwatch.

chriswhocodes avatar chriswhocodes commented on June 2, 2024

Could you let me know what kind of JIT log exhibits the error? One from the Sandbox examples or collected from your own program (-XX:+LogCompilation) ? Thanks

from jitwatch.

alexei-osipov avatar alexei-osipov commented on June 2, 2024

It's collected from my own app. JVM flags used:

-XX:+UnlockDiagnosticVMOptions -XX:+TraceClassLoading -XX:+LogCompilation -XX:-PrintAssembly -XX:LogFile=server_jit.log

(PrintAssembly is turned off for now)

from jitwatch.

alexei-osipov avatar alexei-osipov commented on June 2, 2024

I've just opened sanbox log and it works fine. The problem occurs only on my log.

I'm not sure that this id directly useful but this branch from AbstractLogParser#handleMember is executed for sandbox but not executed for my log:

			case TASK:
			{
				setTagTask((Task) tag, metaMember);
				currentMember = metaMember;
				model.updateStats(metaMember, attrs);
			}

from jitwatch.

alexei-osipov avatar alexei-osipov commented on June 2, 2024

Oh, it seems the main difference that I've opened log on the running app. So the log was incomplete. After the app shutdown JITWatch was able to properly show call/inline chain.

However it's a bit strange that this resulted in NPE.

from jitwatch.

alexei-osipov avatar alexei-osipov commented on June 2, 2024

Thank you!

from jitwatch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.