Giter VIP home page Giter VIP logo

Comments (14)

Coder-Srinivas avatar Coder-Srinivas commented on June 19, 2024

Hey @ADRE9 can I work on this issue as a part of GSSOC'21?

from bunk-manager-mern.

ADRE9 avatar ADRE9 commented on June 19, 2024

@Coder-Srinivas go ahead. @Artistic18 has added the add dialogue and I guess it can be reused. So yes you can use the component.

from bunk-manager-mern.

Coder-Srinivas avatar Coder-Srinivas commented on June 19, 2024

@ADRE9 can you tell me about the contents of the dialog?
Should the name of the subject change or only the days and subject type or all?

from bunk-manager-mern.

ADRE9 avatar ADRE9 commented on June 19, 2024

@Coder-Srinivas check out the edit subject page of the current commit. It's gonna be same as that.

from bunk-manager-mern.

Artistic18 avatar Artistic18 commented on June 19, 2024

@ADRE9 @Coder-Srinivas Yes the component can be reused, you just need to link it properly and do a bit of state modifications.

from bunk-manager-mern.

ADRE9 avatar ADRE9 commented on June 19, 2024

@Coder-Srinivas what's the status?

from bunk-manager-mern.

Coder-Srinivas avatar Coder-Srinivas commented on June 19, 2024

@ADRE9 I have a small doubt, messaged you on discord regarding it.

from bunk-manager-mern.

Artistic18 avatar Artistic18 commented on June 19, 2024

@Coder-Srinivas are you working on this issue?

from bunk-manager-mern.

Artistic18 avatar Artistic18 commented on June 19, 2024

I think no one is working on this issue, I would like to take it.

from bunk-manager-mern.

ADRE9 avatar ADRE9 commented on June 19, 2024

Go ahead.

from bunk-manager-mern.

Artistic18 avatar Artistic18 commented on June 19, 2024

@ADRE9 check this, I have also modified the form to display the days checked which are already present in days array.

Untitled.mp4

from bunk-manager-mern.

ADRE9 avatar ADRE9 commented on June 19, 2024

Looks perfect to me. Its responsive like before?

Make a PR if it is else make it responsive.

from bunk-manager-mern.

Artistic18 avatar Artistic18 commented on June 19, 2024

@ADRE9 yes I have reused the same modal and modified it.

from bunk-manager-mern.

Artistic18 avatar Artistic18 commented on June 19, 2024

@ADRE9 I think I can't push to master because the timetable page has still not been merged with master. So shall I push edit dialog to timetable branch?

from bunk-manager-mern.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.