Messages are translated twice about play-bootstrap HOT 9 CLOSED

Hi! I've just released the non-snapshot version.

from play-bootstrap.

@mvdstam Can you provide a pull request?

from play-bootstrap.

Of course @mkurz: #123 has been opened. Let me know what you think. 👍

from play-bootstrap.

I can't get this to work locally for some reason when I do sbt +publishLocal. I keep getting compilation errors saying object b4 is not a member of package views.htm.

What is the recommended way of doing local development with play-bootstrap so I can see if my suggested changes do what they are supposed to do? 😃

from play-bootstrap.

Hi @mvdstam. Thanks for the PR! It has passed every test like a charm, so I've just merged it and publish the version 1.5.1 as SNAPSHOT. Please check it with your custom MessagesApi.

To work with this library in local for development you have to:

1. I recommend changing the version to a custom one in every build.sbt file.
   core-play27/build.sbt

version := "1.5-P27-TEST-SNAPSHOT"

play27-bootstrap4/module/build.sbt

version := "1.5-P27-B4-TEST-SNAPSHOT"
libraryDependencies ++= Seq(
    "com.adrianhurt" %% "play-bootstrap-core" % "1.5-P27-TEST-SNAPSHOT",
)

2. Compile and publish locally core-play27

cd core-play27 && activator
> clean
> compile
> + publishLocal

3. Compile, test and publish locally play27-bootstrap4/module

cd play27-bootstrap4/module && activator
> clean
> compile
> test
> + publishLocal

4. Change the build.sbt file on your own project to match your new local version for the library
   build.sbt

libraryDependencies ++= Seq(
    "com.adrianhurt" %% "play-bootstrap-core" % "1.5-P27-B4-TEST-SNAPSHOT",
)

5. Play with it!

I hope it works to you, and thanks again! I will update now the docs to add the new 1.5.1 version.

from play-bootstrap.

Hi @adrianhurt, thanks a lot for your instructions.

I've been testing with the 1.5.1-snapshot for B4/P27 and everything seems to work perfectly. No more superfluous messages being translated, so I can see precisely which messages need translations and which don't. Also less function calls now, so it's all a bit more efficient as well. 😃

Can you release and publish 1.5.1?

from play-bootstrap.

@adrianhurt activator is end of life already. You should use sbt instead.

from play-bootstrap.

Hi @adrianhurt, can you please release and publish a non-snapshot version? Thanks!

from play-bootstrap.

Thank you @adrianhurt, cheers.

from play-bootstrap.