Giter VIP home page Giter VIP logo

Comments (4)

shpasha avatar shpasha commented on September 22, 2024 5

My current workaround is:

  • Pass navigator to NavigatorDisposer class, which inherits ScreenDisposable
  • When Screen is disposed NavigatorDisposer also disposes navigator

Sample code:

private class NavigatorDisposer : ScreenDisposable {

    var navigator: Navigator? = null

    override fun onDispose(screen: Screen) {
        navigator?.let { disposeNavigator(it) }
        navigator = null
    }
}

@Composable
private fun Screen.DisposeNavigatorOnScreenDisposeEffect(navigator: Navigator) {
    val screen = this
    LaunchedEffect(navigator) {
        val disposer = ScreenLifecycleStore.get(screen) {
            NavigatorDisposer()
        }
        disposer.navigator = navigator
    }
}

@Composable
public fun Screen.Navigator(
    screen: Screen,
    disposeBehavior: NavigatorDisposeBehavior = NavigatorDisposeBehavior(),
    onBackPressed: OnBackPressed = { true },
    key: String = compositionUniqueId(),
    content: NavigatorContent = { CurrentScreen() }
) {
    Navigator(
        screen = screen,
        disposeBehavior = disposeBehavior,
        onBackPressed = onBackPressed,
        key = key,
        content = { navigator ->
            DisposeNavigatorOnScreenDisposeEffect(navigator)
            content(navigator)
        }
    )
}

But I don't think this is the best way

from voyager.

hristogochev avatar hristogochev commented on September 22, 2024

What would the disposeNavigator function be in your workaround? @shpasha

from voyager.

hristogochev avatar hristogochev commented on September 22, 2024

I believe the solution I've come up with for #402 may also help this issue.

from voyager.

shpasha avatar shpasha commented on September 22, 2024

What would the disposeNavigator function be in your workaround? @shpasha

@hristogochev you can find disposeNavigator function implementation in voyager source codes

from voyager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.