Giter VIP home page Giter VIP logo

Comments (3)

diegoberaldin avatar diegoberaldin commented on July 2, 2024

Hi! I happened to have the same issue (just on one bottom sheet and just in release builds, not in debug ones). Do I have to both remove the SlideTransition and remove the BottomSheetNavigator altogether?

I don't know if it helps, but in my case I have the BottomSheetNavigator as parent and the root navigator as a child, the crash happens just when I call show(screen: Screen) on the former.

EDIT: I realized I am using a third Navigator inside the bottom sheet content, and that is the cause of the issue, this explains why it crashes only with that bottom sheet and not the other plain ones.

from voyager.

RavenLiao avatar RavenLiao commented on July 2, 2024

Hi! I happened to have the same issue (just on one bottom sheet and just in release builds, not in debug ones). Do I have to both remove the SlideTransition and remove the BottomSheetNavigator altogether?

I don't know if it helps, but in my case I have the BottomSheetNavigator as parent and the root navigator as a child, the crash happens just when I call show(screen: Screen) on the former.

EDIT: I realized I am using a third Navigator inside the bottom sheet content, and that is the cause of the issue, this explains why it crashes only with that bottom sheet and not the other plain ones.

Now I use the following code to use BottomSheetNavigator and Transition simultaneously . I hope it will help you.

                Navigator(MainScreen) { navigator ->
                    GlobalNavigatorWrapper(navigator) {
                        MyBottomSheetNavigator {
                            ParcelableNavigatorWrapper {
                                MyCustomTransition(navigator) { screen ->
                                    screen.Content()
                                }
                            }
                        }
                    }
                }


@OptIn(ExperimentalVoyagerApi::class)
@Composable
fun ParcelableNavigatorWrapper(content: @Composable () -> Unit) {
    CompositionLocalProvider(
        LocalNavigatorSaver provides parcelableNavigatorSaver(),
        content = content
    )
}

val LocalGlobalNavigator: ProvidableCompositionLocal<Navigator> =
    staticCompositionLocalOf { error("LocalGlobalNavigator not initialized") }

@Composable
fun GlobalNavigatorWrapper(navigator: Navigator, content: @Composable () -> Unit) {
    CompositionLocalProvider(LocalGlobalNavigator provides navigator, content)
}

from voyager.

diegoberaldin avatar diegoberaldin commented on July 2, 2024

I am removing the nested navigator inside the bottom sheet, I do not actually need it and can achieve a similar behaviour with Crossfade to have a transition.

from voyager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.