Giter VIP home page Giter VIP logo

Comments (5)

DevSrSouza avatar DevSrSouza commented on July 21, 2024 1

Can you share your solution to understand what it is fixing?

from voyager.

DevSrSouza avatar DevSrSouza commented on July 21, 2024

We did have any major changes that could effect this, can you have a look at the diffing between both versions?

1.1.0-alpha04...1.1.0-beta01

from voyager.

Tolriq avatar Tolriq commented on July 21, 2024

Well you migrated the state to KMP. I did not have time to investigate and rolled back, but there's quite a few changes around state save order and the issue was about state save restore.

from voyager.

kaidotarma avatar kaidotarma commented on July 21, 2024

I am experiencing weird UI state issues after upgrading to 1.1.0-beta01 or 1.1.0-beta02.
1.1.0-alpha04 worked well.

The biggest issue for me seems to be that BottomSheetNavigator children (back layer and front layers) don't get new CompositionLocalProvider values. Currently fixed it by adding a wrapper to hold CompositionLocalProvider locally (had to do it in the children).

Don't know if these issues are related, but they seem to be.

Hope someone finds the root cause. :)

from voyager.

kaidotarma avatar kaidotarma commented on July 21, 2024

@DevSrSouza to give an example of the issue, I forked the repo and created a branch with two commits:
Success: kaidotarma@0c63df8
Fail: kaidotarma@5448297

The issue can be seen by these steps:

  1. run the app
  2. open BottomSheet Navigation
  3. see two "Change theme" buttons, click on them
  4. the top one changes only when using 1.1.0-alpha04 and will not change when using 1.1.0-beta01 or 1.1.0-beta02

The code for these buttons are on these lines:
kaidotarma@0c63df8#diff-f299d84b94d315b2ee35f9a74ebb4468bf4c09c9fddf3146981a86352599a87cR40-R46

The issue might be in this library, or related to the update of Compose KMP to 1.6.10
EDIT: Tried reverting back Compose KMP to 1.6.1 - didn't change anything, still the same issue.

from voyager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.