Giter VIP home page Giter VIP logo

Comments (3)

frangarciam avatar frangarciam commented on May 21, 2024

Thanks for catching that, seems like even using the new packages myself for a couple of days was not enough!

Yep, that's a bug alright, we try to avoid things that might depend on cgo on other parts of the code but seems like that one slipped through. I'll fix it on Monday, either removing any reference to the user or relying on a more portable method get the current user.

This gives me another incentive to keep trying to improve our testing framework, which should be easier now that we can automate our builds.

from hologram.

copumpkin avatar copumpkin commented on May 21, 2024

Still curious what the username is used for there, if you have a chance to explain! I tried tracing it through the code but as far as I could tell, they don't get used on the server. The AssumeRoleMsg gets populated with the user but that doesn't seem to ever get read back out?

from hologram.

frangarciam avatar frangarciam commented on May 21, 2024

From what I can see, the username was used at some point in an older version (before hologram was open sourced). From my testing it seems safe to delete and I'll have a PR doing that shortly, but I want to do some more testing first to ensure compatibility (new client with old server, old server with new client, etc...)

Thanks again for reporting and sorry we let this slip, we're working on tightening our testing process.

from hologram.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.