Giter VIP home page Giter VIP logo

Comments (7)

AndreiIgna avatar AndreiIgna commented on July 24, 2024 2

@elliotcondon thanks for adding the hook in ACF. Didn't notice until now is added, tested and works fine.

@rico Looks like "WPFront User Role Editor" needs to override the Menu walker to add its own functionality, and also preserves support for other plugin to hook into it. The option "Override Navigation Menu Permissions" probably is for these use cases.
https://plugins.trac.wordpress.org/browser/wpfront-user-role-editor/trunk/classes/class-wpfront-user-role-editor-nav-menu-walker.php#L192

I will close this, as the change is made in ACF and works as expected

from acf.

AndreiIgna avatar AndreiIgna commented on July 24, 2024

For reference, better support for this is being discussed for years https://core.trac.wordpress.org/ticket/18584 without something concrete being planned

from acf.

elliotcondon avatar elliotcondon commented on July 24, 2024

Hi @AndreiIgna

Thanks for the topic and info. I like your solution (https://github.com/helgatheviking/Nav-Menu-Roles/blob/master/inc/class.Walker_Nav_Menu_Edit_Roles_4.7.php#L66) - this looks neat and tidy to me.

I've had a similar ticket on my to-do for a long time, but never got around to it. I'll make sure I look into this shortly :)

from acf.

AndreiIgna avatar AndreiIgna commented on July 24, 2024

That's great @elliotcondon

As a example, someone is affected by this and ACF fields are not being displayed in menu items https://wordpress.org/support/topic/acf-plugin-conflict-2/

from acf.

rico avatar rico commented on July 24, 2024

@elliotcondon one of my sites is affected by this (Version 5.8.3). Any chance this will be fixed any time soon?

from acf.

elliotcondon avatar elliotcondon commented on July 24, 2024

Hi @rico

We fixed this issue a while ago by adopting a generic Walker_Nav_Menu_Edit class that uses an "wp_nav_menu_item_custom_fields" action.

May I ask which other plugin or theme is causing you the conflict issue?

from acf.

rico avatar rico commented on July 24, 2024

Hi @elliotcondon - ah ok, sorry, thought it is still open.

It's this Plugin: https://wordpress.org/plugins/wpfront-user-role-editor/. However, I figured out that the plugin has a somehow cryptic option called Override Navigation Menu Permissions which seems to overcome the conflict.

If the option is not activated, I get a warning: Menu walker class is overridden by a theme/plugin. Current value = ACF_Walker_Nav_Menu_Edit. Navigation menu permissions may still work.

from acf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.