Giter VIP home page Giter VIP logo

Comments (3)

lancergr avatar lancergr commented on July 1, 2024

Hi @maciek-marcinkowski
Thanks for your feedback and the Pull Request!

This Hybris extension relies on the underlying cart generation mechanism and by design introduces as less business logic as possible.
During the cart initialisation of de.hybris.platform.order.impl.DefaultCartFactory, the user is retrieved from userService.getCurrentUser and this defines the default Hybris behaviour that users would expect. So, on vanilla Hybris the username Guest is used by default.

I see your point on having the user details available for external systems, but I believe this shouldn't be in the scope of the Adyen extension but rather implement the proposed code as:

  • an extra piece of logic within your checkout controllers
  • or custom cart service or checkout facade

Let me know if this is OK with you.

Kind Regards,
Giorgos
Adyen

from adyen-hybris.

maciek-marcinkowski avatar maciek-marcinkowski commented on July 1, 2024

Hi @lancergr

Sorry for my late answer.
I agree that at the very beginning of order placement user 'Guest' is set. However, at the last step of order placement the user is updated with 'First name' and 'Last name' taken from address form. This is an screen from vanilla hybris link and from hybris with Adyen installed link.

The next issue is when we try to create an account after Guest order placement. On vanilla hybris the created account has 'Name' taken from address form and in case of Adyen register it looks like follows (link) vs vanilla Hybris (link).

Best Regards
Maciek

from adyen-hybris.

lancergr avatar lancergr commented on July 1, 2024

Hi @maciek-marcinkowski

Could you check my last reply on your Pull Request?
#50 (comment)

Best Regards,
Giorgos
Adyen

from adyen-hybris.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.