Giter VIP home page Giter VIP logo

Comments (6)

mrkosima avatar mrkosima commented on September 21, 2024 1

As a workaround I'm using:

import type { CoreOptions } from '@adyen/adyen-web/dist/types/core/types';

But I'm agree that it would be much helpful to have exported types in root.

from adyen-web.

iLaurens avatar iLaurens commented on September 21, 2024 1

I would like to see this as well. In my case I am using the custom card integration (secured fields) and I wanted to make it more robust by using TypeScript. I tried mapping function signatures manually for functions like create, onChange, onError etc but found it difficult to find the correct typings due to arbitrary naming and such. I could also imagine that these internals may change with patch releases while they would end up on the integrating side as breaking changes. If types get exported, it would be great if they are precise instead of using types like any or object.

from adyen-web.

Benjamindudok avatar Benjamindudok commented on September 21, 2024 1

As a workaround I'm using:

import type { CoreOptions } from '@adyen/adyen-web/dist/types/core/types';

But I'm agree that it would be much helpful to have exported types in root.

We used this workaround too. Though probably an update somewhere in our build system 'broke' this method because the types aren't in the 'exports' of the package. Which probably has something to do with Typescript not completely adhering to ESM module specifications (yet).

We're now getting the following error in our project with Vue 3 using Vite:

[ERROR] [plugin vite:dep-scan] Missing "./dist/types/core" export in "@adyen/adyen-web" package

Which is pretty much the same as this issue in the vite repository: vitejs/vite#7749.

from adyen-web.

WoodyWoodsta avatar WoodyWoodsta commented on September 21, 2024

I'm looking for this as well.

from adyen-web.

DanielRitvas avatar DanielRitvas commented on September 21, 2024

Up.It would actually be very useful to be able to import types via npm! I'm using the library as an embedded script so there is no way to access types in the code at the moment in any way.

from adyen-web.

Fifciu avatar Fifciu commented on September 21, 2024

Up. I would love to import types easily. For now, I am using:

import type { CoreOptions } from "@adyen/adyen-web/dist/types/core/types";
import type { DropinElementProps } from "@adyen/adyen-web/dist/types/components/Dropin/types";

But it would be much better to import just from the @adyen/adyen-web.

I've just prepared a very simple PR addressing this issue: #2294

from adyen-web.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.