Giter VIP home page Giter VIP logo

Comments (9)

pandeiro avatar pandeiro commented on August 23, 2024

This appears to be a regression from 0.1.7 to 0.1.8

from boot-cljs-repl.

martinklepsch avatar martinklepsch commented on August 23, 2024

Confirmed with 0.1.8.

from boot-cljs-repl.

pandeiro avatar pandeiro commented on August 23, 2024

Additionally I've noticed that with 0.1.7, the REPL connection is established only if there is no *.cljs.edn build specified (ie, the default 'main.js' is generated). When I do specify builds, the port appears in the server output but the client-side connection function is never called.

(Using boot-cljs from master, not clojars)

from boot-cljs-repl.

martinklepsch avatar martinklepsch commented on August 23, 2024

I guess it must be somewhere in this commit.

What's confusing to me is that in the weasel-connection function there is a 0 passed as port when none is specified but this has been the case before that commit as well?!

from boot-cljs-repl.

martinklepsch avatar martinklepsch commented on August 23, 2024

I just tested this with 0.0-2755 which ships some REPL fixes and that seems to fix the problem. I'll PR the boot-cljs repo. @pandeiro when I made that PR it'd be awesome if you could verify that what I'm saying is correct.

from boot-cljs-repl.

martinklepsch avatar martinklepsch commented on August 23, 2024

Just tested with 0.0-2760 and works fine. Still prints 0 as port:

boot.user=> (start-repl)
<< started Weasel server on ws://127.0.0.1:0 >>
Type `:cljs/quit` to stop the ClojureScript REPL
Writing boot_cljs_repl.cljs...

from boot-cljs-repl.

martinklepsch avatar martinklepsch commented on August 23, 2024

REPLs still breaking in projects that use CLJSJS-like libraries.

from boot-cljs-repl.

pkobrien avatar pkobrien commented on August 23, 2024

Is this still an outstanding issue?

from boot-cljs-repl.

martinklepsch avatar martinklepsch commented on August 23, 2024

Probably not. That new weasel stuff worked well when I tested it and this is really old anyways.

from boot-cljs-repl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.