Giter VIP home page Giter VIP logo

Comments (5)

Deraen avatar Deraen commented on May 27, 2024

Obviously the URL (ws://:62480) is invalid as it is missing hostname. What is strange is that 0.4.8 is working fine for me.

Also, not related to this, but I don't recommend using target task in development task. I wrote short piece about this at boot-cljs wiki: https://github.com/adzerk-oss/boot-cljs/wiki/Serving-files

from boot-reload.

Deraen avatar Deraen commented on May 27, 2024

Problem is probably here: https://github.com/adzerk-oss/boot-reload/blob/master/src/adzerk/boot_reload/client.cljs#L24

Either ws-host is empty string (it should be nil), or js/window.location.hostname is empty. If you have time to check, it would be helpful if you can debug that function, console.log call should work fine:

(defn resolve-url [url ws-host]
  (let [passed-uri (Uri. url)
        protocol   (.getScheme passed-uri)
        host       (or ws-host (.-hostname (.-location js/window)))
        port       (.getPort passed-uri)]
    (js/console.log "ws-host" ws-host "hostname" (.-hostname (.-location js/window)))
    (str protocol "://" host ":" port)))

from boot-reload.

paultopia avatar paultopia commented on May 27, 2024

Oh god. It was my moronic mistake, and a total false alarm. Very sorry! I'm using a weird dev setup where I'm shoving compiled cljs files into an otherwise javascript-only chrome extension in a different project, and I just realized that I've been working with them from the file directly rather than from localhost. Which is why window.location.hostname was indeed empty. Very embarrassing... sorry for wasting your time.

from boot-reload.

Deraen avatar Deraen commented on May 27, 2024

No problem :)

Also, when you are directly working with files, I think setting ws-host manually will work.

from boot-reload.

Deraen avatar Deraen commented on May 27, 2024

And as this seems like case useful to guard against, I added a warning message which hopefully makes the problem clear: 4a43890

from boot-reload.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.