Possible GC optimization for Value types about aerospike-client-go HOT 5 CLOSED

Type Alias is a neat trick! Hadn't thought of it. Will be in the next release.

Regarding pre-packing, I'm aware of the implications. I agree with you on principle.

The reason why it is implemented in this way is that all bin values are preceded by a header indicating their size. I haven't been able to come up with a clean solution that would not require an intermediate buffer. What this implies is that the buffer that returns the packed array cannot be the same as the final buffer, since we need the result first to write the header.

I also do not want to call the packer twice, once for size estimation, and once to write the result to the buffer.

Thoughts?

from aerospike-client-go.

What I can think of is to write the header with 0 as size first (if the size field is in fixed length), then pack the value and get the length, and then go back to change the size field in the header. Not very clean but may work.

from aerospike-client-go.

The Value optimizations are in. Thanks for the tip.

I'll try to come up with a better solution for complex data types.

from aerospike-client-go.

Thanks for the improvements!

For NullValue, may want to avoid allocation (and avoid pointer) as well:
type NullValue struct{}
var nullValue NullValue
func NewNullValue() NullValue {
return nullValue
}

from aerospike-client-go.

Done.

from aerospike-client-go.