Giter VIP home page Giter VIP logo

Comments (8)

shekhar-shubhendu avatar shekhar-shubhendu commented on August 16, 2024

ping/pong can be handled on the transport layer but this is mainly useful for apps using postMessage API.

from aexs.

davidyuk avatar davidyuk commented on August 16, 2024

I was guessing that it is for WebSocket or so, but I can't get how it can be used in postMessage interface. Can you explain it?

from aexs.

shekhar-shubhendu avatar shekhar-shubhendu commented on August 16, 2024

postMessage is a simple API to send/broadcast messages additionally allowing us to specify a target for the message. When a browser wallet extension connects to the SDK over postMessage we don't really know(even right after the connect message) whether the wallet is present or not until we receive the next message or the sign request from the SDK fails.

We can rely on the message failures or on the wallet letting SDK know that it disconnecting but from my point of view using ping/pong to detect wallet connection will provide a much better user experience as there will be no sudden changes/failures in the app and things can be handled gracefully.

from aexs.

knarz avatar knarz commented on August 16, 2024

Please, if possible, use the discussion link, if available, for issues related to specific AEXs.

from aexs.

davidyuk avatar davidyuk commented on August 16, 2024

@shekhar-shubhendu Are there any cases when wallet can't call wallet.disconnect.aepp before closing? Anyway, aepp can poll aepp.get.address method that shouldn't be expensive if such polling is needed in some weird case.

from aexs.

davidyuk avatar davidyuk commented on August 16, 2024

@shekhar-shubhendu this issue is still actual for AEX-5

from aexs.

shekhar-shubhendu avatar shekhar-shubhendu commented on August 16, 2024

@davidyuk will have to think about it. but most probably with latest version of aex-2 this should also be removed.

from aexs.

marc0olo avatar marc0olo commented on August 16, 2024

no longer relevant, AEX-5 is withdrawn. I am wondering if we should propose a new standard for wallet connections. seems like this has generally been a big pain in the past

from aexs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.