Giter VIP home page Giter VIP logo

Comments (6)

shekhar-shubhendu avatar shekhar-shubhendu commented on July 17, 2024

@davidyuk the first part is not very clear as I don't know how base app generates child accounts. can you please expand on this?
AEX-3 allows arbitrary data and recommends that it should be user related but it can not enforce the type of data the wallet can store.

from aexs.

davidyuk avatar davidyuk commented on July 17, 2024

Here is my implementation of account derivation in Base app: https://github.com/aeternity/hd-wallet-js/blob/master/src/hd-wallet.js
And some explanations: aeternity/aepp-sdk-js#41 (comment)

If secret_type doesn't have any strict meaning, let's drop it for now.

from aexs.

shekhar-shubhendu avatar shekhar-shubhendu commented on July 17, 2024

@knarz will be able to provide more information on this since he is the original author here.

from aexs.

knarz avatar knarz commented on July 17, 2024

Right now I imagine the secret_type to be taken quite literally in the sense that it is a private key, which should be used to generate signatures according to ed25519.
I'd rather include more types and keep the field around s.t. the files can be self-contained.
Otherwise we either specify that a version field with value 1 should indicate to a reader that it contains above key material or we add more types to the spec. What would you suggest?

from aexs.

davidyuk avatar davidyuk commented on July 17, 2024

I think AEX-3 becomes more useful if we get rid of the ambiguity of secret_type field by adding more types like:

  • ed25519-bip39-mnemonic, or just mnemonic?
  • ed25519-slip0010-masterkey
  • aex*-account -- a key that can be used to derive subaccounts
  • aex*-keypair -- derived key

where aex* is a standard explaining account derivation. Also, it is important to define the payload layout for all types to get consistent implementations.

from aexs.

knarz avatar knarz commented on July 17, 2024

Addressed in b762e6d, please re-open if that doesn't solve the problem

from aexs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.