Comments (7)
as these issues deal with syntactic changes and not the core functionality provided by the proposal, therefore, these will be added either in this sprint or the next. thanks for the contribution.
for some of the issues stated I suggest you to please re-read the proposal.
from aexs.
yes, but it can lead to breaking changes in AEX-2
from aexs.
yes, but it can lead to breaking changes in AEX-2
these will be handled with sample implementation on AEX finalization. No need to worry I think right now.
from aexs.
for some of the issues stated I suggest you to please re-read the proposal
for which issues?
from aexs.
Wallet methods
- what is return value of
aepp.get.address
method?
Already part of the AEX. Please re-read.
- in what format tx should be passed to
aepp.request.sign
method? I see several options: hex string, an array of bytes,tx_..
string, the current explanation is too ambiguous
Will be added.
- in what format tx returned from
aepp.request.sign
method?
Will be added. same as above.
- for what reason
aepp.request.sign
and other methods should returnid
received in arguments?
Already part of the AEX. Please re-read.
Aepp methods
- what is return value of
wallet.get.network
method?
Already part of the AEX. Please re-read.
- how aepp can use a list of connected account returned from
wallet.update.address
if it can't switch between them? We either should drop it or add a method for account switching.- can
wallet.update.address
be simplified by extracting of getting a list of connected accounts into a separate method?
Not required.
wallet.update.address
method should explain parameters explicitly, not only by providing an example
Not required.
- for what reason
wallet.broadcast.tx
andwallet.verify.tx
methods?
Already part of the AEX. Please re-read.
Common issues
- add errors that can be thrown by method to explanation of every method
Error explation are descriptive enough.
- how
aepp.update.network
andwallet.get.network
methods are supposed to work?
Already part of the AEX. Please re-read.
from aexs.
Will be added.
Can you explain it better than "Currently supported format: tx_
string"? Maybe add a link to some document explaining what is tx_
string? #34, #35
for what reason aepp.request.sign and other methods should return id received in arguments?
Already part of the AEX. Please re-read.
I can't find, can you point to specific part?
for what reason wallet.broadcast.tx and wallet.verify.tx methods?
Already part of the AEX. Please re-read.
Yes, I see them, in which cases they are necessary?
Error explation are descriptive enough
So, let's remove errors explanations from wallet.broadcast.tx
, wallet.verify.tx
methods for consistency.
from aexs.
All unresolved issues are moved to separate issues
from aexs.
Related Issues (20)
- AEX-1: Aeternity expansion process
- AEX-2: Third-party Wallet Provider Support HOT 3
- AEX-3: Secret storage format
- AEX-4: æternity wallet deep linking specification HOT 1
- AEX-5: Inter-Wallet Communication HOT 3
- AEX-6: Strategic Semantic Syntax Part 1: Contract Interaction Wrapper HOT 2
- AEX-7: Data Serialization HOT 2
- AEX-8: Message Signing
- AEX-9: Fungible Token Standard HOT 5
- AEX-10: Derivation path for deterministic wallets HOT 1
- AEX-11: Compliant Fungible Token Standard
- Verifiable off-chain state for accounts
- AEX-5: Simplify methods names HOT 1
- AEX-129: Data Serialization
- AEX-130: æpps Metadata Format Specification
- Proposal: Aliased denominations HOT 2
- Extension for AEX-9: Include payload HOT 2
- AEX-2 - passing config data to the wallet ? HOT 3
- Non-Fungible Token standard HOT 75
- Request for clarification and potential improvements: AEX-3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aexs.