Giter VIP home page Giter VIP logo

Comments (7)

shekhar-shubhendu avatar shekhar-shubhendu commented on August 16, 2024

as these issues deal with syntactic changes and not the core functionality provided by the proposal, therefore, these will be added either in this sprint or the next. thanks for the contribution.

for some of the issues stated I suggest you to please re-read the proposal.

from aexs.

davidyuk avatar davidyuk commented on August 16, 2024

yes, but it can lead to breaking changes in AEX-2

from aexs.

shekhar-shubhendu avatar shekhar-shubhendu commented on August 16, 2024

yes, but it can lead to breaking changes in AEX-2

these will be handled with sample implementation on AEX finalization. No need to worry I think right now.

from aexs.

davidyuk avatar davidyuk commented on August 16, 2024

for some of the issues stated I suggest you to please re-read the proposal

for which issues?

from aexs.

shekhar-shubhendu avatar shekhar-shubhendu commented on August 16, 2024

Wallet methods

  • what is return value of aepp.get.address method?

Already part of the AEX. Please re-read.

  • in what format tx should be passed to aepp.request.sign method? I see several options: hex string, an array of bytes, tx_.. string, the current explanation is too ambiguous

Will be added.

  • in what format tx returned from aepp.request.sign method?

Will be added. same as above.

  • for what reason aepp.request.sign and other methods should return id received in arguments?

Already part of the AEX. Please re-read.

Aepp methods

  • what is return value of wallet.get.network method?

Already part of the AEX. Please re-read.

  • how aepp can use a list of connected account returned from wallet.update.address if it can't switch between them? We either should drop it or add a method for account switching.
  • can wallet.update.address be simplified by extracting of getting a list of connected accounts into a separate method?

Not required.

  • wallet.update.address method should explain parameters explicitly, not only by providing an example

Not required.

  • for what reason wallet.broadcast.tx and wallet.verify.tx methods?

Already part of the AEX. Please re-read.

Common issues

  • add errors that can be thrown by method to explanation of every method

Error explation are descriptive enough.

  • how aepp.update.network and wallet.get.network methods are supposed to work?

Already part of the AEX. Please re-read.

from aexs.

davidyuk avatar davidyuk commented on August 16, 2024

Will be added.

Can you explain it better than "Currently supported format: tx_ string"? Maybe add a link to some document explaining what is tx_ string? #34, #35

for what reason aepp.request.sign and other methods should return id received in arguments?

Already part of the AEX. Please re-read.

I can't find, can you point to specific part?

for what reason wallet.broadcast.tx and wallet.verify.tx methods?

Already part of the AEX. Please re-read.

Yes, I see them, in which cases they are necessary?

Error explation are descriptive enough

So, let's remove errors explanations from wallet.broadcast.tx, wallet.verify.tx methods for consistency.

from aexs.

davidyuk avatar davidyuk commented on August 16, 2024

All unresolved issues are moved to separate issues

from aexs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.