Giter VIP home page Giter VIP logo

Comments (7)

shekhar-shubhendu avatar shekhar-shubhendu commented on July 17, 2024

Will be added to the rationale section and then let's discuss it in the forums.

from aexs.

davidyuk avatar davidyuk commented on July 17, 2024

@shekhar-shubhendu how #57 resolves this issue?

from aexs.

shekhar-shubhendu avatar shekhar-shubhendu commented on July 17, 2024

as you can see this method has been removed from the aex-2 and we've added a notification for the wallet and app to inform the other party about change in network so that they can handle the requests appropriately.

wallet/app can inform other party about the network change but they can not enforce or trigger a network change.

from aexs.

davidyuk avatar davidyuk commented on July 17, 2024

Have you updated the rationale section as you promised in the message above? Is there any practical use cases when aepp need to inform wallet about network id? Isn't enough that network id is a part of the transaction that aepp sends to a wallet for signing?

from aexs.

shekhar-shubhendu avatar shekhar-shubhendu commented on July 17, 2024

Let's assume the wallet wants to maintain a list of aepps it is/has connected to then it would be a nice feature for the wallet to show this detail there. this was the user can just open the wallet and see which aepp is on which network without going to check this on the aepp side.
if this info is part of the sign request then wallet can only say what was the network id of the last signed tx.

from aexs.

davidyuk avatar davidyuk commented on July 17, 2024

What if aepps resets network id to mainnet by default? Then the user will assume that aepp uses testnet but after opening it will appear to be connected to mainnet. It makes "without going to check this on the aepp side" a bad strategy.

#56 proposes to store supported networks in app metadata, it is better because wallet shouldn't open aepp to know it's network id.

from aexs.

shekhar-shubhendu avatar shekhar-shubhendu commented on July 17, 2024

@davidyuk as suggested, this functionality will be removed

from aexs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.