Giter VIP home page Giter VIP logo

Comments (8)

AndreasGassmann avatar AndreasGassmann commented on July 17, 2024 2

Can't we just have another AEX later that extends this one? All I'm saying is that if we include this here, it will take longer. And as far as I'm aware, there is currently no concrete plan to use inter-wallet communication, so maybe let's just wait until there is and we can make decisions based on the limitations and use-cases we encounter then.

from aexs.

shekhar-shubhendu avatar shekhar-shubhendu commented on July 17, 2024 1

@emil-apeunit would be the best person to provide details here.

from aexs.

shekhar-shubhendu avatar shekhar-shubhendu commented on July 17, 2024

it would be best to keep them different as aex-5 will does not treats 2 wallets differently as in base-aepp i.e. "master" and "slave".
both the connected wallets are treated same and can forward request to one another.
moreover, these two things are different functionalities and therefore should be kept separate.

from aexs.

davidyuk avatar davidyuk commented on July 17, 2024

Is it really needed to sign transactions in both directions? Can you provide some practical use cases? If it is needed, why they can't call aepp.request.sign from AEX-2?

from aexs.

AndreasGassmann avatar AndreasGassmann commented on July 17, 2024

While I agree that those 2 proposals are somewhat related, I think they should be kept separate simply because it's a completely different use case and I would also argue that AEX-2 is more important right now, AEX-5 is more something that could be used in the future. So we should try to move AEX-2 forward as fast as possible, and then adjust AEX-5 so it builds upon AEX-2.

from aexs.

davidyuk avatar davidyuk commented on July 17, 2024

I'm not sure that they are completely different use cases. For example, MyEtherWallet implements support of MetaMask in a way that MetaMask shouldn't implement any special interfaces for inner-wallet communication, and it works fine. Do we need additional interfaces for inner-wallet communication?

from aexs.

davidyuk avatar davidyuk commented on July 17, 2024

Ok, but in future, I will vote for not doing a separate standard for inter-wallet communication because AEX-2 already implements that.

from aexs.

emil-apeunit avatar emil-apeunit commented on July 17, 2024

@davidyuk I'm also very much in favor of keeping them separate, but AEX-5 can extend AEX-2 so that we don't have unnecessary duplicates.

from aexs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.