Change env: any to env: NodeJS.ProcessEnv about envalid HOT 4 CLOSED

I'm +1 for this, @SimenB ?

from envalid.

I don't use TS, so I don't really care either way, to be honest 😛 I do think supporting the use of cleanEnv({PORT: 8080}) is useful, but maybe type correctness is more useful?

from envalid.

I do think supporting the use of cleanEnv({PORT: 8080}) is useful

This is the distinction I draw between parsing environment variables and validating generic object schemas. Since you've provided a hard-coded value of 8080, I'd argue that you're no longer parsing environment variables.

From the The Twelve-Factor App:

Apps sometimes store config as constants in the code. This is a violation of twelve-factor, which requires strict separation of config from code. Config varies substantially across deploys, code does not.

If you want a generic object validator that asserts that a property is port-like, then that could be extracted and shipped as its own module (which envalid could consume), but that should be outside the scope of cleanEnv IMO.

from envalid.

I agree, the focus of this lib is specifically for env var validation. This issue gives a very well-reasoned explanation why this is a worthwhile change, and shouldn't disrupt the existing tests. I'd be happy to merge a PR for this 👍

from envalid.